From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blqiK-0004K0-3z for qemu-devel@nongnu.org; Mon, 19 Sep 2016 01:01:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blqiG-0003US-1Y for qemu-devel@nongnu.org; Mon, 19 Sep 2016 01:01:55 -0400 Date: Mon, 19 Sep 2016 15:00:16 +1000 From: David Gibson Message-ID: <20160919050016.GA20488@umbus> References: <1474029551-17739-1-git-send-email-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: <1474029551-17739-1-git-send-email-lvivier@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/5] spapr: convert SPAPR devices to trace framework List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: eblake@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org --liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 16, 2016 at 02:39:06PM +0200, Laurent Vivier wrote: > Define and use trace_spapr_XXX functions instead of > DPRINTF to trace some SPAPR devices: spapr_vio, spapr_drc, spapr_rtas, > spapr_llan, spapr_vscsi. >=20 > This allows to enable dynamically (instead of recompiling the source) > the traces for these devices. Messages are close as possible as > messages used by DPRINTF. Sometime, I've removed some text to > avoid redundancy between information given by the tracing function name > and the text displayed. I've also updated print format to use > the good conversion specifier ('u' instead of 'd' when the type is unsign= ed, > PRIx32 instead of 'x' when the type is uint32_t or int32_t, ...) >=20 > v2: > - fix spapr_vscsi with "ust" backend (limited number of arguments) > - Remove blank line after the comment line in trace-events files > - add Eric's R-b >=20 > David, you can take only patch 5/5, all the other patches are like they > are in your branch ppc-for-2.8. Done, thanks. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --liOOAslEiF7prFVr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX33DdAAoJEGw4ysog2bOSIFEP/itZOjUh5kJ9FTQbubWd/kbT GOj3HKypfifFH3DsvvNBhp0DKbe/lZ8g0r2b+tqEFU/ro0y3HtenVd9teAB7+zt4 SqctcY2I4zROGSUv9s+9gFxdOGU+SWudwUxeY5NfhPVAHCBjMMkK0wIS3QgDEZWN pCw3f5oGiNmgUFRb2MvxKUt17L+lVpC5c9i+mFzsqBQNCZWY/ECq0mY2p/3rfi2X xBN7KVvc+8wZsDfr46Kat8HYJ1ZzV+MVH+fr1wmANe+fImhclGaLgZyQaof6jJnt 7kXfOQ0ACIy/LAIG8l3AUVTex2lKCQgc1lm7FXjLfW0R17+32M3wToqePAbdcIvc 36/z7VO5c5pwYDRJhYcrwxrl6DxtlIfgwPZjCgOW7qiFxDrwDZpgDRA962Ay4FL9 nfybLVixqY3ALpmO6AG9tjgGZcu1S/ZbrXCj0KhhTeINOntovGOj2ThZIW3PmqIi 4sXwz5obM814qa7Vl/FOSmFql+GnQDnIfbAgKpaaxjD9xf9zP8aIpbmdqgsQlrmb aqRS7di8zTmO5Y0BLb8xLlFvV4KuJwzZKW3UEmxyCg7HBnINPQt4ECd4wkIcGDc2 LeLYHZgYaeH00pKaPJmORYna2t79mkKLDEe0lA65HMNiM78kQl20iMjnxo8/c6xV VgAqAqhWo3k6E/WpWhkN =E5Mx -----END PGP SIGNATURE----- --liOOAslEiF7prFVr--