From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blyvE-0000d7-Gt for qemu-devel@nongnu.org; Mon, 19 Sep 2016 09:47:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blyv9-0003sa-VW for qemu-devel@nongnu.org; Mon, 19 Sep 2016 09:47:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blyv9-0003rr-M6 for qemu-devel@nongnu.org; Mon, 19 Sep 2016 09:47:43 -0400 Date: Mon, 19 Sep 2016 14:47:37 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20160919134736.GC2041@work-vm> References: <1472117833-10236-1-git-send-email-dgilbert@redhat.com> <1472117833-10236-2-git-send-email-dgilbert@redhat.com> <87wpi8f310.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <87wpi8f310.fsf@dusky.pond.sub.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] qapi: Stub out StringOutputVisitor struct support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com, afaerber@suse.de, kwolf@redhat.com, pbonzini@redhat.com, arei.gonglei@huawei.com * Markus Armbruster (armbru@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: >=20 > > From: "Dr. David Alan Gilbert" > > > > Avoid a segfault when visiting, e.g., the QOM rtc-time property, > > by implementing the struct callbacks and raising an Error. > > > > Signed-off-by: Andreas F=E4rber > > > > Updated for changed interface: > > Signed-off-by: Dr. David Alan Gilbert > > --- > > qapi/string-output-visitor.c | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visito= r.c > > index 94ac821..4e7e97f 100644 > > --- a/qapi/string-output-visitor.c > > +++ b/qapi/string-output-visitor.c > > @@ -12,6 +12,7 @@ > > =20 > > #include "qemu/osdep.h" > > #include "qemu-common.h" > > +#include "qapi/error.h" > > #include "qapi/string-output-visitor.h" > > #include "qapi/visitor-impl.h" > > #include "qemu/host-utils.h" > > @@ -266,6 +267,16 @@ static void print_type_number(Visitor *v, const = char *name, double *obj, > > string_output_set(sov, g_strdup_printf("%f", *obj)); > > } > > =20 > > +static void start_struct(Visitor *v, const char *name, void **obj, s= ize_t size, > > + Error **errp) > > +{ > > + error_setg(errp, "struct type not implemented"); > > +} > > + > > +static void end_struct(Visitor *v, void **obj) > > +{ > > +} > > + >=20 > This is just one of the several things this visitor doesn't implement. > See the comment in string-output-visitor.h. >=20 > String input visitor and options visitor have similar holes; see the > comments in string-input-visitor.h and opts-visitor.h. >=20 > Should we change all of them together to report errors instead of crash= ? > With common "error out because this isn't implemented" methods? In that case wouldn't it be best to change visit_start_struct/visit_end_s= truct to do the check (Like visit_check_struct does). Dave >=20 > > static void > > start_list(Visitor *v, const char *name, GenericList **list, size_t = size, > > Error **errp) > > @@ -356,6 +367,8 @@ Visitor *string_output_visitor_new(bool human, ch= ar **result) > > v->visitor.end_list =3D end_list; > > v->visitor.complete =3D string_output_complete; > > v->visitor.free =3D string_output_free; > > + v->visitor.start_struct =3D start_struct; > > + v->visitor.end_struct =3D end_struct; > > =20 > > return &v->visitor; > > } -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK