From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bm0D4-0007N1-0B for qemu-devel@nongnu.org; Mon, 19 Sep 2016 11:10:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bm0Cz-0005zi-VE for qemu-devel@nongnu.org; Mon, 19 Sep 2016 11:10:17 -0400 Date: Mon, 19 Sep 2016 17:10:02 +0200 From: Kevin Wolf Message-ID: <20160919151002.GE4546@noname.redhat.com> References: <1471625435-6190-1-git-send-email-kwolf@redhat.com> <1471625435-6190-5-git-send-email-kwolf@redhat.com> <20160915083514.GA4726@noname.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uAKRQypu60I7Lcqm" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 04/10] block: Accept device model name for blockdev-open/close-tray List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-block@nongnu.org, mreitz@redhat.com, qemu-devel@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau --uAKRQypu60I7Lcqm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 15.09.2016 um 17:51 hat Eric Blake geschrieben: > On 09/15/2016 03:35 AM, Kevin Wolf wrote: >=20 > >>> =20 > >>> -- "device": block device name (json-string) > >>> +- "device": block device name (deprecated, use @id instead) > >>> + (json-string, optional) > >>> +- "id": the name or QOM path of the guest device (json-string, optio= nal) > >>> - "force": if false (the default), an eject request will be sent to = the guest if > >>> it has locked the tray (and the tray will not be opened i= mmediately); > >>> if true, the tray will be opened regardless of whether it= is locked > >> > >> Are there any example code snippets that should be updated alongside > >> this? If not, should we be thinking of adding an example? > >=20 > > We could probably update the examples to avoid deprecated fields in > > them. Though the old examples still work, so is it worth changing all > > examples if we're goig to remove qmp-commands.hx anyway? Or will the > > examples be moved to somewhere else? >=20 > Marc-Andre is moving the examples into qapi-schema.json (and friends), > over the course of multiple commits. It's going to be a lot of churn > and potential merge conflicts, based on what changes go into > qmp-commands.hx after his work starts, but hopefully we can avoid things > slipping through the cracks, without too much rebase pain on either > Marc-Andre or other developers. Ok, I'm changing the examples from 'device' to 'id' now. And actually the first one immediately made me notice that the DEVICE_TRAY_MOVED event needs to be changed, too (because its 'device' field can be empty now). Matter for another series, but I put it on my list. Kevin --uAKRQypu60I7Lcqm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJX3//KAAoJEH8JsnLIjy/WeIwP/iTM3UE8TK75JJ8QlJCRHg36 IOt12cktAK+lSlx2HFS/nHxyt7BGSYhzrTGPUjF/j04WlumPLGGEA72pVeLx7trA nC/WjBxqnV0A9dvu1MUTt93E7ThDfWzFt80KwkSgBMmH4XOV7HnUN4dJfcgCyc9i GumiqteO8pyo5peCXQOQeQcQGO8tcT35/PKasLdyjCXWs0D4VaqOPCcgvUJYtkyf AaVkJb3VoSPRpK1NhrQVJpGkFt1vekYvb8h6s+oH/pZoXcfYwjfdATNRhBaRWSsJ ARNRzAOF/4jyPR7wqALj9pM4UEdCEXo+cFgmtFUQpcAdEP+lu3oSr3/J5wRGdb4O X3zjMoPMmElfDA3YcdbQEYdX+evo5eczN3Tt8wYR3mLRmkYH9glIibLZajcutZ78 gTxCfFKgPHzgfI0uPD8ogBeKcitr5MbGcDbzcnaU9VKb8FMm0TSstBa6mebYQ2hO AdaC7jHupOh3pZ0oAR/3pX1AU+CU6XZMBEndHHbxh9BBTwy7E1iBBHTrT6qbSqKS KShhNw+NEEiwnW/K0BzIBruQFHZGgc/JD7yEQrYSthuri7+AqrBFw5EZhEqZf4Fw 0ye7ZN+dywbpQEo4pLs2v/F8xmoHO+cbIHQRjn+vQ3d5VDrHWcOlclMUYlSuM2tm eHKb+PGMphmbqqQEXtBG =G3jW -----END PGP SIGNATURE----- --uAKRQypu60I7Lcqm--