From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56167)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bm2UI-0007ee-KZ
	for qemu-devel@nongnu.org; Mon, 19 Sep 2016 13:36:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bm2Id-0006XY-4K
	for qemu-devel@nongnu.org; Mon, 19 Sep 2016 13:24:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52766)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bm2Ic-0006XE-US
	for qemu-devel@nongnu.org; Mon, 19 Sep 2016 13:24:11 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 58BA0808FF
	for <qemu-devel@nongnu.org>; Mon, 19 Sep 2016 17:24:10 +0000 (UTC)
Date: Mon, 19 Sep 2016 18:24:07 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160919172407.GY15201@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <1474296549-29171-1-git-send-email-berrange@redhat.com>
	<1474296549-29171-4-git-send-email-berrange@redhat.com>
	<87lgynakph.fsf@fimbulvetr.bsc.es>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <87lgynakph.fsf@fimbulvetr.bsc.es>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 03/18] trace: remove some now unused
 functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Mon, Sep 19, 2016 at 07:00:26PM +0200, Llu=C3=ADs Vilanova wrote:
> Daniel P Berrange writes:
>=20
> > The trace_event_count, trace_event_id and
> > trace_event_pattern methods are no longer required
> > now that everything is using the iterator APIs
>=20
> > The trace_event_set_state and trace_event_set_vcpu_state
> > macros were also unused.
>=20
> Wouldn't it make more sense to fold the removal of trace_event_pattern(=
) into
> the previous patch?

No - that would be mixing two changes in one commit. There are two
logically separate changes here - one is changing an internal
implementation detail, and one is altering the public API to remove
methods.

Regards,
Daniel
--=20
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange=
/ :|
|: http://libvirt.org              -o-             http://virt-manager.or=
g :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr=
/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vn=
c :|