From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmJZg-0004sc-Fr for qemu-devel@nongnu.org; Tue, 20 Sep 2016 07:50:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmJZb-00029G-BB for qemu-devel@nongnu.org; Tue, 20 Sep 2016 07:50:55 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39153 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmJZb-000291-56 for qemu-devel@nongnu.org; Tue, 20 Sep 2016 07:50:51 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8KBlmoC134056 for ; Tue, 20 Sep 2016 07:50:50 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0b-001b2d01.pphosted.com with ESMTP id 25jkn4hu0d-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 20 Sep 2016 07:50:50 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 20 Sep 2016 12:50:49 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 23361219005E for ; Tue, 20 Sep 2016 12:50:08 +0100 (BST) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8KBolDE11076052 for ; Tue, 20 Sep 2016 11:50:47 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u8KBolKp009677 for ; Tue, 20 Sep 2016 05:50:47 -0600 Date: Tue, 20 Sep 2016 13:50:45 +0200 From: Cornelia Huck In-Reply-To: <1460467534-29147-10-git-send-email-stefanha@redhat.com> References: <1460467534-29147-1-git-send-email-stefanha@redhat.com> <1460467534-29147-10-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20160920135045.57203c3a.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH v3 09/10] virtio: handle virtqueue_num_heads() errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Fam Zheng On Tue, 12 Apr 2016 14:25:33 +0100 Stefan Hajnoczi wrote: > If the avail ring index is bogus virtqueue_num_heads() must return > -EINVAL. > > The only caller is virtqueue_get_avail_bytes(). Return saying no bytes > are available when virtqueue_num_heads() fails. > > Signed-off-by: Stefan Hajnoczi > --- > hw/virtio/virtio.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) Reviewed-by: Cornelia Huck