From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmLpp-0007YR-TO for qemu-devel@nongnu.org; Tue, 20 Sep 2016 10:15:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmLpk-0007jG-FZ for qemu-devel@nongnu.org; Tue, 20 Sep 2016 10:15:45 -0400 Date: Tue, 20 Sep 2016 15:15:28 +0100 From: "Daniel P. Berrange" Message-ID: <20160920141528.GO25490@redhat.com> Reply-To: "Daniel P. Berrange" References: <1474306544-24708-1-git-send-email-berrange@redhat.com> <1474306544-24708-2-git-send-email-berrange@redhat.com> <5a389739-00eb-48a2-188b-31030337e3eb@redhat.com> <20160920093635.GA25490@redhat.com> <6a34a3f9-7ac4-ab53-1921-40a8e21a6a88@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6a34a3f9-7ac4-ab53-1921-40a8e21a6a88@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/6] iotests: throw away test timings if args change List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz On Tue, Sep 20, 2016 at 09:06:17AM -0500, Eric Blake wrote: > On 09/20/2016 04:36 AM, Daniel P. Berrange wrote: > >> Rather than completely throwing things away, would it be worth updating > >> the check.time file format to track multiple entries? For every distinct > >> args seen, track a timing for that combination of args, then when > >> starting a test, if a line in the file contains the current args, report > >> that old time; if not, then append a line with the new args. The file > >> grows according to how many distinct args combinations you use, and it's > >> probably easier to make 'a b' and 'b a' report as different timings even > >> if they have the same effect and could share a timing. We'd also want > >> an operation to clean out timings without running tests, particularly if > >> timings can otherwise grow huge due to every possible args combination. > >> > >> What do you think? > > > > I was afraid someone would suggest a more complex scheme like that :-) > > > > I guess we could keep things simple by not inventing a new format, > > but instead of using 'check.time', use 'check.time.$FORMAT-$PROTOCOL' > > eg 'check.time.qcow2-file' > > Seems more palatable. Lots of files rather than lots of lines in a > single file; searching is now fast (if you can come up with the right > file name, the OS does the searching for you rather than us having to > figure out which (if any) portion of a large file applies). We may > still want a command for easily cleaning everything, and if we do switch > to new file names, we'll still want to clean up the old files. Isn't that command called 'git clean -f' - if we remove 'check.time' from the gitignore file, it'll be deleted by a git clean, without needing to ass the -i flag. I don't think we really need to reinvent a special way to clean just these timing files, particularly since they are not large. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|