From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmNpr-0004e6-GX for qemu-devel@nongnu.org; Tue, 20 Sep 2016 12:23:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmNpm-0002c7-DS for qemu-devel@nongnu.org; Tue, 20 Sep 2016 12:23:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmNpm-0002bu-5A for qemu-devel@nongnu.org; Tue, 20 Sep 2016 12:23:50 -0400 Date: Tue, 20 Sep 2016 18:23:45 +0200 From: Igor Mammedov Message-ID: <20160920182345.7ed48f45@nial.brq.redhat.com> In-Reply-To: <20160920181358-mutt-send-email-mst@kernel.org> References: <1470984850-66891-1-git-send-email-guangrong.xiao@linux.intel.com> <1470984850-66891-2-git-send-email-guangrong.xiao@linux.intel.com> <20160920160757.3fdc2ce8@nial.brq.redhat.com> <20160920181358-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/8] acpi nvdimm: fix wrong buffer size returned by DSM method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Xiao Guangrong , ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On Tue, 20 Sep 2016 18:14:48 +0300 "Michael S. Tsirkin" wrote: > On Tue, Sep 20, 2016 at 04:07:57PM +0200, Igor Mammedov wrote: > > As sanity check I'd suggest to extract nvdimm ssdt in guest, decompile and compile it back. > > Currently I can't compile it back which mean it's really broken. > > Not always true, disassembler is sometimes producing weird code. > But it's a strong hint. Unfortunately in current master it's broken as keyword ARG_FOO is used as field name