From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47634)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1bmQM8-0001XN-03
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 15:05:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1bmQM4-0004fi-OO
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 15:05:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37596)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1bmQM4-0004fZ-Hx
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 15:05:20 -0400
Date: Tue, 20 Sep 2016 16:05:17 -0300
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20160920190517.GF3233@thinpad.lan.raisama.net>
References: <1474314175-24374-1-git-send-email-ehabkost@redhat.com>
	<1474314175-24374-5-git-send-email-ehabkost@redhat.com>
	<be884b2f-eb07-2f90-4f7a-8dc921a6de52@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <be884b2f-eb07-2f90-4f7a-8dc921a6de52@redhat.com>
Subject: Re: [Qemu-devel] [libvirt] [PATCH v3 4/5] qmp: Add runnability
 information to query-cpu-definitions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Christian Borntraeger <borntraeger@de.ibm.com>, libvir-list@redhat.com, dahi@linux.vnet.ibm.com, Cornelia Huck <cornelia.huck@de.ibm.com>, Igor Mammedov <imammedo@redhat.com>, Jiri Denemark <jdenemar@redhat.com>

On Tue, Sep 20, 2016 at 01:25:06PM -0500, Eric Blake wrote:
> On 09/19/2016 02:42 PM, Eduardo Habkost wrote:
> > Add a new optional field to query-cpu-definitions schema:
> > "unavailable-features". It will contain a list of QOM properties
> > that prevent the CPU model from running in the current host.
> > 
> > Cc: David Hildenbrand <dahi@linux.vnet.ibm.com>
> > Cc: Michael Mueller <mimu@linux.vnet.ibm.com>
> > Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> > Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
> > Cc: Jiri Denemark <jdenemar@redhat.com>
> > Cc: libvir-list@redhat.com
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> 
> > +++ b/qapi-schema.json
> > @@ -3111,10 +3111,31 @@
> >  #          QEMU version, machine type, machine options and accelerator options.
> >  #          A static model is always migration-safe. (since 2.8)
> >  #
> > +# @unavailable-features: #optional List of properties that prevent
> > +#                        the CPU model from running in the current
> > +#                        host. (since 2.7)
> 
> We've missed 2.7; this should probably be 2.8.  Otherwise reads okay to me;
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Oops! I will fix it before merging. Thanks for spotting!

-- 
Eduardo