From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmXld-00026r-9G for qemu-devel@nongnu.org; Tue, 20 Sep 2016 23:00:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmXlZ-00069u-4x for qemu-devel@nongnu.org; Tue, 20 Sep 2016 23:00:12 -0400 Date: Wed, 21 Sep 2016 12:15:25 +1000 From: David Gibson Message-ID: <20160921021525.GS20488@umbus> References: <1473943560-14846-1-git-send-email-clg@kaod.org> <1473943560-14846-6-git-send-email-clg@kaod.org> <20160921015156.GP20488@umbus> <1474423547.2857.109.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="m9CJymqw5zZ14Dg6" Content-Disposition: inline In-Reply-To: <1474423547.2857.109.camel@kernel.crashing.org> Subject: Re: [Qemu-devel] [PATCH v3 05/10] ppc/pnv: add a PnvCore object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: =?iso-8859-1?Q?C=E9dric?= Le Goater , qemu-ppc@nongnu.org, qemu-devel@nongnu.org --m9CJymqw5zZ14Dg6 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 21, 2016 at 12:05:47PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2016-09-21 at 11:51 +1000, David Gibson wrote: > > Ok, as noted elsewhere, I think you need to disassociate the PIR value > > from the cpu_index.=A0 It may be a little less elegant, but it'll make > > your life much easier in the short and medium term. > >=20 > > Apart from that, this looks pretty good, though I have one suggested > > cleanup below. >=20 > As long as the PIR value is what is used everywhere, ie, interrupt > controller, XSCOM addressing of the cores, Doorbells, etc... Right, obviously the physical ID needs to be used for all the guest visible interfaces. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --m9CJymqw5zZ14Dg6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX4e09AAoJEGw4ysog2bOSCZQP/RAitMChipctwc6BOb4Z4UXa bSfouOcSyLNm9As9Mey1gXiSjmCap8kg9CqYz8G4KGv6EchPUC19esGd4NA4wKZ/ QD0bqTNBWLg3ZVzpyy8Mto3Kd78WXuKelJPoRK0IsYCpxiZN4hICU4nY8i0Cauyg 01pVBhnQEt00w+aIHCXlJc8wK77AGT6mzbo1LF4EtGCh0nOwb9oIX/p6aRTwT0yv VEb1AiCr+gvCr/592OALNdPPueZuL/6WmFw5YDE2hiDQoBHfirlNSXky1/9RxAFD k9jWTsuKwJePhelUyhM/bal4zJhFWRypMwloDy4c6w0JUQ9TwItwYpjYcSjrxiS0 V21Sp5ZeCb6GJninA8wBdKIH6pXcORFev02vUQhpsFoWknah3fky9jW/obvY1TAC oyggSrpAWA2/EkEqzkZ2ak44wQiGw9Go6VI6TnadZ1+eDmOMwxbR/dbA7e6WhRaT niRZse2/NBgzOaoV6lr1U0DECh1ks9msMymffiPEbLR369h3UfMKqeRx0bYQgJ6L jkqPGXDgeqLbDHFvz5rVGb7BQBp/CSw7H8lwgcRn4SZ7nOpI/d+n7P/Uz0L7A8P9 cv2EwBD6bRSx3EpVjlY0hmDX7iScCule/jtkLJcWmZcTn1lOJvJQEIBS2xv3Au5p 2pa2WtqaVEDxlcVX9gTd =CuJK -----END PGP SIGNATURE----- --m9CJymqw5zZ14Dg6--