From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmYM3-0007F9-Qi for qemu-devel@nongnu.org; Tue, 20 Sep 2016 23:37:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmYM2-0003ji-Sh for qemu-devel@nongnu.org; Tue, 20 Sep 2016 23:37:51 -0400 Date: Wed, 21 Sep 2016 13:18:09 +1000 From: David Gibson Message-ID: <20160921031809.GT20488@umbus> References: <20160814225339.482797.79805@ex-std-node742.prod.rhcloud.com> <1471219193.12231.78.camel@kernel.crashing.org> <1471219913.12231.80.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vTm+q/AqrlpK2neZ" Content-Disposition: inline In-Reply-To: <1471219913.12231.80.camel@kernel.crashing.org> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, famz@redhat.com --vTm+q/AqrlpK2neZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 15, 2016 at 10:11:53AM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2016-08-15 at 09:59 +1000, Benjamin Herrenschmidt wrote: > > Bla bla bla bla ... > >=20 > > Seriously, we have nazi stylebot on the list now ? > >=20 > > I made conscious decisions to style it this way and as far as the tabs > > in the .h are concerned, that's because the file is lifted from Linux > > and I'd like to keep it intact as much as possible. >=20 > There are actually a couple of places where I agree with the style > change, so I'll include that in a futher post after more useful review > has been posted (seriously, stylebots are just infuriating). So.. as irritating as you find the bot, there are a bunch of gratuitous style problems. In particular sungem.c itself isn't consistent about whether it has 8 char or 4 char indentation. That really does need to be fixed. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --vTm+q/AqrlpK2neZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX4fvvAAoJEGw4ysog2bOS1zcQAKRPJ1acB7UNGU49R+JnCVA3 LNiffYF2kOnF/TCmQ9hdIeOG0Qlyv9jOgi954vD1EDtTBYlUfsuxFhhpC7Dzd0c+ ANHIrzFV+kkKDEWPWiLfk6HZX4wJACYULuvHv82eiYKw5H08SJVXYJvWt6nKei+p PX9dh+4XrMp3yqsS5GNQgBv9y9zvI2jeBRrkv4FopsPNBE1qjahbYormUkVVN06Q g+Wt+Li5Wp+gdqZaDlA3ENvQObywNvnIwU4tSbMSSy1Fn1n8Urp9gxkIaB2lWWoD MhGtDmRvpx99TNl+uBWNhPsiiSx6LOAJb5D+u8ObsJVh/fAWzFikaHt20wtEnEuB Euv6xOhJPorTP3Gg1nxWJcl4n4NVartNsiu8P17iDSHuCpXuoJPAn4Cdau48JXcm ev7Iyeg+OnbcS5ariASEagIjIpQgclweK8E05LeAYtzyiwDjNGHM++84OG6vI6Ra NU1l9Fomz/CoIm5rHJvURqXO2r7oU43229Wlz1eg4Ema2S+hvGLQOftZuFiZmSJz H7q6DD9GZCTo8/xFcxqnagX+6ye4sjHBSRv7wnj69owQlbjuGBziOC+0JNF3xQNf d97yd3PfvxsqL43uWa5sCtFBsfJeFVQVwK3OCtbOR1Fiwy1RUs2gDwZ5s8wvS8YU Ah/o6CZsTnh8m9WvQM58 =ampL -----END PGP SIGNATURE----- --vTm+q/AqrlpK2neZ--