From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40634)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1bmaEv-0001rV-Iy
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 01:38:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1bmaEr-00010M-FV
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 01:38:36 -0400
Date: Wed, 21 Sep 2016 15:30:01 +1000
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20160921053001.GY20488@umbus>
References: <1473943560-14846-1-git-send-email-clg@kaod.org>
	<1473943560-14846-7-git-send-email-clg@kaod.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="+mfs7XF4MJu0zTM1"
Content-Disposition: inline
In-Reply-To: <1473943560-14846-7-git-send-email-clg@kaod.org>
Subject: Re: [Qemu-devel] [PATCH v3 06/10] monitor: fix crash for platforms
 without a CPU 0
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?C=E9dric?= Le Goater <clg@kaod.org>
Cc: qemu-ppc@nongnu.org, Benjamin Herrenschmidt <benh@kernel.crashing.org>, qemu-devel@nongnu.org


--+mfs7XF4MJu0zTM1
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 15, 2016 at 02:45:56PM +0200, C=E9dric Le Goater wrote:
> On PowerNV, CPU ids start at 0x8 or 0x20, we don't have a CPU 0
> anymore. So let's use the first_cpu index to initialize the monitor.
>=20
> Signed-off-by: C=E9dric Le Goater <clg@kaod.org>

I've rewritten the commit message to make the case for this without
the context of pnv and posted upstream.

> ---
>  monitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/monitor.c b/monitor.c
> index 5c003731e288..0192209a7915 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -1023,7 +1023,7 @@ int monitor_set_cpu(int cpu_index)
>  CPUState *mon_get_cpu(void)
>  {
>      if (!cur_mon->mon_cpu) {
> -        monitor_set_cpu(0);
> +        monitor_set_cpu(first_cpu->cpu_index);
>      }
>      cpu_synchronize_state(cur_mon->mon_cpu);
>      return cur_mon->mon_cpu;

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--+mfs7XF4MJu0zTM1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJX4hrWAAoJEGw4ysog2bOS4a4P/3wSehiPRBo6VdvReFUCzQax
OdgchCK6RxGmKKrA8GwWjXvxECytxt1q1Mp3dwcYScSprbnoYENFkPD5LfFgLiaY
jOORNSRvvCQwbhBdVbJMXXwYjBrodXp1sPgy0kyyDKlxHwQQGlVlbaYNDlo3GwKQ
/EmOLQZ3GM3tV59FDr2hHgm8xVOCbOnnPUU3VeSE6OmYjJOCW7SFyVHUps/bcLRl
+jSTufvTnEWOBz8cGvXuo4VlNP9BCazwNlUx8PQpdpAeBO5SOt47mFyYG0GfohIn
DgS8FM2YFxESfhIrg/Qfc2jnJX0RFK2yMYMqDNA+PRCyBv/V2cPSLxttHwSLUwqv
70XoYU0JaMh+ZXKZcgKKLZ4v3x8uHqiJGQfVUFKET8YV556wR5JUkkPKEgolOqs4
Bu3AZ9p0O7CuXqZosZuZ+aqQWECvUQxRgEzWCeJ1QZbp2nS1IYXXCqD5EFcSr0KW
iOe469zxunrpag1P7bwmh3h2m9aIGVgtNyCt0/dlRfbFiZbHHJDu7hqEXLZy77YA
ooHatMkzyPr5vt+KcNQfxOAoEWeq4JwUPnGdxkyCv8mQKXDhFyx0M5MEN5bAUKp9
yeattQ93x4NWB8xZJQkVYD5CSbEOA/xand0VILccUACyaglYydZsW0DrRmUNpwBE
y98qck7z8gIMGwnixrO1
=aWbX
-----END PGP SIGNATURE-----

--+mfs7XF4MJu0zTM1--