From: Peter Xu <peterx@redhat.com>
To: "Wu, Feng" <feng.wu@intel.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] intel-iommu: Check IOAPIC's Trigger Mode against the one in IRTE
Date: Wed, 21 Sep 2016 14:12:17 +0800 [thread overview]
Message-ID: <20160921061217.GI5134@pxdev.xzpeter.org> (raw)
In-Reply-To: <E959C4978C3B6342920538CF579893F01987B5A8@SHSMSX104.ccr.corp.intel.com>
On Wed, Sep 21, 2016 at 05:54:40AM +0000, Wu, Feng wrote:
>
>
> > -----Original Message-----
> > From: Peter Xu [mailto:peterx@redhat.com]
> > Sent: Wednesday, September 21, 2016 1:45 PM
> > To: Wu, Feng <feng.wu@intel.com>
> > Cc: qemu-devel@nongnu.org; pbonzini@redhat.com
> > Subject: Re: [Qemu-devel] [PATCH] intel-iommu: Check IOAPIC's Trigger Mode
> > against the one in IRTE
> >
> > On Thu, Sep 22, 2016 at 12:12:17AM +0800, Feng Wu wrote:
> > > The Trigger Mode field of IOAPIC must match the Trigger Mode in
> > > the IRTE according to VT-d Spec 5.1.5.1.
> > >
> > > Signed-off-by: Feng Wu <feng.wu@intel.com>
> >
> > Reviewed-by: Peter Xu <peterx@redhat.com>
> >
> > Could I ask why we want this now? I know that both vector and trigger
> > mode should not be aligned in current kernel.
>
> Oh, I don't aware of this. I was just looking at the code and found seems
> the Spec says we need to check it. So I added the check. :)
Yeah, that's good enough a reason. :-)
-- peterx
next prev parent reply other threads:[~2016-09-21 6:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 16:12 [Qemu-devel] [PATCH] intel-iommu: Check IOAPIC's Trigger Mode against the one in IRTE Feng Wu
2016-09-21 5:45 ` Peter Xu
2016-09-21 5:54 ` Wu, Feng
2016-09-21 6:12 ` Peter Xu [this message]
2016-09-21 6:34 ` Wu, Feng
2016-09-28 10:05 ` Wu, Feng
2016-09-28 10:21 ` Paolo Bonzini
2016-09-28 10:34 ` Peter Xu
2016-09-28 10:56 ` Wu, Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921061217.GI5134@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=feng.wu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).