From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55770)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmd53-0003J6-AQ
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:40:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmd4y-00032S-6f
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:40:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55850)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmd4y-00032M-16
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:40:32 -0400
Date: Wed, 21 Sep 2016 09:40:28 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160921084028.GF15535@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <1474429768-25027-1-git-send-email-famz@redhat.com>
	<1474429768-25027-6-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1474429768-25027-6-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/9] docker: Flatten default target list in
 test-quick
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>

On Wed, Sep 21, 2016 at 11:49:24AM +0800, Fam Zheng wrote:
> Previously it is expanded to a whitespace separated list which is not
> the most appropriate format. Since it's only two items, flatten it.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/docker/test-quick | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/docker/test-quick b/tests/docker/test-quick
> index 07cdc59..7885dfa 100755
> --- a/tests/docker/test-quick
> +++ b/tests/docker/test-quick
> @@ -13,7 +13,7 @@
>  
>  . common.rc
>  
> -DEF_TARGET_LIST="$(echo {x86_64,aarch64}-softmmu)"
> +DEF_TARGET_LIST="x86_64-softmmu,aarch64-softmmu"
>  TARGET_LIST=${TARGET_LIST:-$DEF_TARGET_LIST} \
>  build_qemu
>  make check $MAKEFLAGS

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|