Re: [Qemu-devel] [PATCH 6/9] docker: Print used options before doing configure

["Daniel P. Berrange" <berrange@redhat.com>]

On Wed, Sep 21, 2016 at 11:49:25AM +0800, Fam Zheng wrote:
> This makes the configure command more obvious which usually has useful
> information.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/docker/common.rc | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 0c6d8d5..510a3ad 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -23,11 +23,13 @@ requires()
>  
>  build_qemu()
>  {
> -    $QEMU_SRC/configure \
> -        --enable-werror \
> -        ${TARGET_LIST:+"--target-list=${TARGET_LIST}"} \
> -        --prefix="$PWD/install" \
> -        $EXTRA_CONFIGURE_OPTS \
> -        "$@"
> +    config_opts="--enable-werror \
> +                 ${TARGET_LIST:+--target-list=${TARGET_LIST}} \
> +                 --prefix=$PWD/install \
> +                 $EXTRA_CONFIGURE_OPTS \
> +                 $@"
> +    echo "Configure options:"
> +    echo $config_opts
> +    $QEMU_SRC/configure $config_opts
>      make $MAKEFLAGS
>  }

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|