From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56911)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmd85-00060y-VZ
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:43:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmd82-0003mu-PK
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:43:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57326)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bmd82-0003mj-Io
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 04:43:42 -0400
Date: Wed, 21 Sep 2016 09:43:38 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160921084338.GJ15535@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <1474429768-25027-1-git-send-email-famz@redhat.com>
	<1474429768-25027-10-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1474429768-25027-10-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 9/9] docker: exec $CMD
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>

On Wed, Sep 21, 2016 at 11:49:28AM +0800, Fam Zheng wrote:
> This is the last command to run (unless DEBUG), make it 'exec' to
> simplify the process tree.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/docker/run | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/docker/run b/tests/docker/run
> index ed7dd31..c1e4513 100755
> --- a/tests/docker/run
> +++ b/tests/docker/run
> @@ -57,14 +57,17 @@ cd "$QEMU_SRC/tests/docker"
>  
>  CMD="$QEMU_SRC/tests/docker/$@"
>  
> -if test -n "$DEBUG"; then
> -    echo "* Prepared to run command:"
> -    echo "  $CMD"
> -    echo "* Hit Ctrl-D to continue, or type 'exit 1' to abort"
> -    echo
> -    $SHELL
> +if test -z "$DEBUG"; then
> +    exec $CMD
>  fi
>  
> +# DEBUG workflow
> +echo "* Prepared to run command:"
> +echo "  $CMD"
> +echo "* Hit Ctrl-D to continue, or type 'exit 1' to abort"
> +echo
> +$SHELL
> +
>  if "$CMD"; then
>      exit 0
>  elif test -n "$DEBUG"; then

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|