qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org,
	sw@weilnetz.de, jcody@redhat.com, mdroth@linux.vnet.ibm.com,
	armbru@redhat.com, pbonzini@redhat.com, mreitz@redhat.com,
	rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v9 07/13] tests: No longer dependent on CONFIG_UUID
Date: Wed, 21 Sep 2016 09:45:15 +0100	[thread overview]
Message-ID: <20160921084515.GL15535@redhat.com> (raw)
In-Reply-To: <1474432046-325-8-git-send-email-famz@redhat.com>

On Wed, Sep 21, 2016 at 12:27:20PM +0800, Fam Zheng wrote:
> crypto now uses built-in uuid implementation, so this check is not
> needed.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Jeff Cody <jcody@redhat.com>
> ---
>  tests/test-crypto-block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/test-crypto-block.c b/tests/test-crypto-block.c
> index a38110d..1957a86 100644
> --- a/tests/test-crypto-block.c
> +++ b/tests/test-crypto-block.c
> @@ -28,7 +28,7 @@
>  #include <sys/resource.h>
>  #endif
>  
> -#if defined(CONFIG_UUID) && (defined(_WIN32) || defined RUSAGE_THREAD)
> +#if (defined(_WIN32) || defined RUSAGE_THREAD)
>  #define TEST_LUKS
>  #else
>  #undef TEST_LUKS

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

  reply	other threads:[~2016-09-21  8:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21  4:27 [Qemu-devel] [PATCH v9 00/13] UUID clean ups for 2.8 Fam Zheng
2016-09-21  4:27 ` [Qemu-devel] [PATCH v9 01/13] util: Add UUID API Fam Zheng
2016-09-21  4:27 ` [Qemu-devel] [PATCH v9 02/13] uuid: Make null_uuid static Fam Zheng
2016-09-21  4:27 ` [Qemu-devel] [PATCH v9 03/13] vhdx: Use QEMU UUID API Fam Zheng
2016-09-21  4:27 ` [Qemu-devel] [PATCH v9 04/13] vdi: " Fam Zheng
2016-09-21  4:27 ` [Qemu-devel] [PATCH v9 05/13] vpc: " Fam Zheng
2016-09-21  4:27 ` [Qemu-devel] [PATCH v9 06/13] crypto: Switch to " Fam Zheng
2016-09-21  8:44   ` Daniel P. Berrange
2016-09-21  4:27 ` [Qemu-devel] [PATCH v9 07/13] tests: No longer dependent on CONFIG_UUID Fam Zheng
2016-09-21  8:45   ` Daniel P. Berrange [this message]
2016-09-21  4:27 ` [Qemu-devel] [PATCH v9 08/13] configure: Remove detection code for UUID Fam Zheng
2016-09-21  4:27 ` [Qemu-devel] [PATCH v9 09/13] vl: Switch qemu_uuid to QemuUUID Fam Zheng
2016-09-21  4:27 ` [Qemu-devel] [PATCH v9 10/13] uuid: Tighten uuid parse Fam Zheng
2016-09-21  4:27 ` [Qemu-devel] [PATCH v9 11/13] tests: Add uuid tests Fam Zheng
2016-09-21  4:27 ` [Qemu-devel] [PATCH v9 12/13] Add UUID files to MAINTAINERS Fam Zheng
2016-09-21  8:48   ` Daniel P. Berrange
2016-09-21  4:27 ` [Qemu-devel] [PATCH v9 13/13] tests: Ignore test-uuid Fam Zheng
2016-09-21  5:56   ` Jeff Cody
2016-09-21  8:49   ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160921084515.GL15535@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).