qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, jasowang@redhat.com,
	quintela@redhat.com, pbonzini@redhat.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH v4 3/8] block: don't make snapshots for filters
Date: Wed, 21 Sep 2016 14:33:21 +0300	[thread overview]
Message-ID: <20160921113320.1420.80132.stgit@PASHA-ISP.def.inno> (raw)
In-Reply-To: <20160921113303.1420.63544.stgit@PASHA-ISP.def.inno>

This patch disables snapshotting for block driver filters.
It is needed, because snapshots should be created
in underlying disk images, not in filters itself.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 block/snapshot.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/block/snapshot.c b/block/snapshot.c
index bf5c2ca..8998b8b 100644
--- a/block/snapshot.c
+++ b/block/snapshot.c
@@ -184,6 +184,9 @@ int bdrv_snapshot_goto(BlockDriverState *bs,
     if (!drv) {
         return -ENOMEDIUM;
     }
+    if (drv->is_filter) {
+        return 0;
+    }
     if (drv->bdrv_snapshot_goto) {
         return drv->bdrv_snapshot_goto(bs, snapshot_id);
     }

  parent reply	other threads:[~2016-09-21 11:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21 11:33 [Qemu-devel] [PATCH v4 0/8] replay additions Pavel Dovgalyuk
2016-09-21 11:33 ` [Qemu-devel] [PATCH v4 1/8] record/replay: add network support Pavel Dovgalyuk
2016-09-23  6:06   ` Jason Wang
2016-09-23  7:52     ` Pavel Dovgalyuk
2016-10-13  8:01     ` Pavel Dovgalyuk
2016-09-21 11:33 ` [Qemu-devel] [PATCH v4 2/8] replay: save/load initial state Pavel Dovgalyuk
2016-09-21 15:39   ` Paolo Bonzini
2016-09-21 15:49     ` Pavel Dovgalyuk
2016-09-21 15:57       ` Paolo Bonzini
2016-09-22  5:37         ` Pavel Dovgalyuk
2016-09-22  8:51           ` Paolo Bonzini
2016-09-21 11:33 ` Pavel Dovgalyuk [this message]
2016-09-21 15:37   ` [Qemu-devel] [PATCH v4 3/8] block: don't make snapshots for filters Paolo Bonzini
2016-09-22  5:43     ` Pavel Dovgalyuk
2016-09-21 11:33 ` [Qemu-devel] [PATCH v4 4/8] block: implement bdrv_recurse_is_first_non_filter for blkreplay Pavel Dovgalyuk
2016-09-21 11:33 ` [Qemu-devel] [PATCH v4 5/8] replay: move internal data to the structure Pavel Dovgalyuk
2016-09-21 11:33 ` [Qemu-devel] [PATCH v4 6/8] replay: vmstate for replay module Pavel Dovgalyuk
2016-09-21 11:33 ` [Qemu-devel] [PATCH v4 7/8] replay: allow replay stopping and restarting Pavel Dovgalyuk
2016-09-21 11:33 ` [Qemu-devel] [PATCH v4 8/8] integratorcp: adding vmstate for save/restore Pavel Dovgalyuk
2016-09-21 15:40 ` [Qemu-devel] [PATCH v4 0/8] replay additions Paolo Bonzini
2016-09-22  5:41   ` Pavel Dovgalyuk
2016-09-22  8:51     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160921113320.1420.80132.stgit@PASHA-ISP.def.inno \
    --to=pavel.dovgaluk@ispras.ru \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).