From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmjrL-0006wi-Hb for qemu-devel@nongnu.org; Wed, 21 Sep 2016 11:54:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmjrJ-0007bK-J5 for qemu-devel@nongnu.org; Wed, 21 Sep 2016 11:54:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmjrJ-0007b8-CK for qemu-devel@nongnu.org; Wed, 21 Sep 2016 11:54:53 -0400 Date: Wed, 21 Sep 2016 16:54:48 +0100 From: "Daniel P. Berrange" Message-ID: <20160921155448.GY15535@redhat.com> Reply-To: "Daniel P. Berrange" References: <877fa5aiu4.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <877fa5aiu4.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v11 0/8] Add a generic loader List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Alistair Francis , peter.maydell@linaro.org, crosthwaitepeter@gmail.com, pbonzini@redhat.com, qemu-devel@nongnu.org, cov@codeaurora.org On Wed, Sep 21, 2016 at 08:05:23AM +0200, Markus Armbruster wrote: > Alistair Francis writes: > > > This work is based on the original work by Li Guang with extra > > features added by Peter C and myself. > > > > The idea of this loader is to allow the user to load multiple images > > or values into QEMU at startup. > > > > Memory values can be loaded like this: -device loader,addr=0xfd1a0104,data=0x8000000e,data-len=4 > > > > Images can be loaded like this: -device loader,file=./images/u-boot.elf,cpu=0 > > I know it's way too late for design questions, but the thought just > occured to me: -device gives you what you need without defining yet > another command line option (good!), but is it appropriate? It's not > exactly a device... Would -object be a better fit? I honestly don't > know. Paolo? Yes, -object would be better. Basically -device is used to create stuff which is related to guest ABI, while -object is used to create anything else, which is basically host integration stuff. Loading firmeware images is clearly host integration, so belongs in -object Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|