Re: [Qemu-devel] [PATCH] checkpatch: downgrade "architecture specific defines should be avoided"

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1474476607-4990-1-git-send-email-pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH] checkpatch: downgrade "architecture specific defines should be avoided"

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/1474435433-9029-1-git-send-email-david@gibson.dropbear.id.au -> patchew/1474435433-9029-1-git-send-email-david@gibson.dropbear.id.au
 * [new tag]         patchew/1474476607-4990-1-git-send-email-pbonzini@redhat.com -> patchew/1474476607-4990-1-git-send-email-pbonzini@redhat.com
 * [new tag]         patchew/147447700612.30952.9420141963781948805.stgit@bahia -> patchew/147447700612.30952.9420141963781948805.stgit@bahia
 * [new tag]         patchew/1474477573-6386-1-git-send-email-lvivier@redhat.com -> patchew/1474477573-6386-1-git-send-email-lvivier@redhat.com
Switched to a new branch 'test'
ada0573 checkpatch: downgrade "architecture specific defines should be avoided"

=== OUTPUT BEGIN ===
Checking PATCH 1/1: checkpatch: downgrade "architecture specific defines should be avoided"...
ERROR: line over 90 characters
#18: FILE: scripts/checkpatch.pl:2410:
+			WARN("architecture specific defines should be avoided\n" .  $herecurr);

ERROR: Missing Signed-off-by: line(s)

total: 2 errors, 0 warnings, 8 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org