From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40724)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1bmuUw-0000Ks-3A
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 23:16:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1bmuUr-0008Ac-N5
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 23:16:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38566)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1bmuUr-0008AY-GQ
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 23:16:25 -0400
Date: Thu, 22 Sep 2016 11:16:21 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20160922031621.GM5134@pxdev.xzpeter.org>
References: <1474475244-28151-1-git-send-email-wei@redhat.com>
	<1474475244-28151-2-git-send-email-wei@redhat.com>
	<20160922023417.GL5134@pxdev.xzpeter.org>
	<bffbb48d-8da2-8868-21e5-26e062d34e5c@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <bffbb48d-8da2-8868-21e5-26e062d34e5c@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for 2.8 2/2] Added Traditional Chinese
 translation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wei Huang <wei@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, famz@redhat.com

On Wed, Sep 21, 2016 at 09:44:03PM -0500, Wei Huang wrote:
> 
> 
> On 09/21/2016 09:34 PM, Peter Xu wrote:
> > On Wed, Sep 21, 2016 at 11:27:24AM -0500, Wei Huang wrote:
> >> Add Traditional Chinese (zh_TW) translation to QEMU. The translations
> >> use other virt software, such as virt-manger, as references.
> >>
> >> CC: Peter Xu <peterx@redhat.com>
> >> CC: Fam Zheng <famz@redhat.com>
> >> Signed-off-by: Wei Huang <wei@redhat.com>
> > 
> > Reviewed-by: Peter Xu <peterx@redhat.com>
> > 
> > So we are using traditional Chinese? That's fine to me though. :)
> > 
> > How can I try it? I tried to:
> > 
> >   $ LANG="zh_CN.UTF-8" $QEMU_CMDLINE
> > 
> > But what I see is still "???" on all the buttons. I must have missed
> > some steps here.
> 
> The language will be picked up automatically based on locale setting. I
> saw QEMU is missing zh_TW and just went ahead to add it. What you did is
> right, but there is a bug in QEMU. You can apply the patch in
> https://patchwork.ozlabs.org/patch/558872/ and revert 2cb5d2a4 to
> display the characters correctly.

Yes it worked. Thanks!

-- peterx