qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Riku Voipio <riku.voipio@iki.fi>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Timothy Pearson <tpearson@raptorengineering.com>,
	Allan Wirth <awirth@akamai.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: fix TARGET_NR_select
Date: Thu, 22 Sep 2016 04:25:46 +0000	[thread overview]
Message-ID: <20160922042546.GA25484@kos.to> (raw)
In-Reply-To: <b24c7a7d-2505-25fe-a290-ccdaa9e220b4@vivier.eu>

On Sun, Sep 04, 2016 at 03:49:22PM +0200, Laurent Vivier wrote:
> Le 11/07/2016 à 18:59, Peter Maydell a écrit :
> > On 8 July 2016 at 00:17, Laurent Vivier <laurent@vivier.eu> wrote:
> >> TARGET_NR_select can have three different implementations:
> >>
> >>   1- to always return -ENOSYS
> >>
> >>      microblaze, ppc, ppc64
> >>
> >>      -> TARGET_WANT_NI_OLD_SELECT
> >>
> >>   2- to take parameters from a structure pointed by arg1
> >>     (kernel sys_old_select)
> >>
> >>      i386, arm, m68k
> >>
> >>      -> TARGET_WANT_OLD_SYS_SELECT
> >>
> >>   3- to take parameters from arg[1-5]
> >>      (kernel sys_select)
> >>
> >>      x86_64, alpha, s390x,
> >>      cris, sparc, sparc64
> >>
> >> Some (new) architectures don't define NR_select,
> >>
> >>   4- but only NR__newselect with sys_select:
> >>
> >>       mips, mips64, sh
> >>
> >>   5- don't define NR__newselect, and use pselect6 syscall:
> >>
> >>       aarch64, openrisc, tilegx, unicore32
> >>
> >> Reported-by: Timothy Pearson <tpearson@raptorengineering.com>
> >> Reported-by: Allan Wirth <awirth@akamai.com>
> >> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> >> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> >> ---
> > 
> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> > 
> 
> It seems this one has missed 2.7 window, perhaps it can queued for 2.8?

Thanks for the reminder, applied to linux-user que

Riku

      reply	other threads:[~2016-09-22  4:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07 23:17 [Qemu-devel] [PATCH] linux-user: fix TARGET_NR_select Laurent Vivier
2016-07-08  0:55 ` Wirth, Allan
2016-07-11 16:59 ` Peter Maydell
2016-09-04 13:49   ` Laurent Vivier
2016-09-22  4:25     ` Riku Voipio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160922042546.GA25484@kos.to \
    --to=riku.voipio@iki.fi \
    --cc=awirth@akamai.com \
    --cc=laurent@vivier.eu \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=tpearson@raptorengineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).