From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55338)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <voipio@kos.to>) id 1bmvaD-0001vU-Ij
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 00:26:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <voipio@kos.to>) id 1bmva8-0006HO-My
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 00:26:00 -0400
Received: from jessie.kos.to ([212.47.231.226]:46898 helo=pilvi.kos.to)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <voipio@kos.to>) id 1bmva8-0006Fe-Hi
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 00:25:56 -0400
Date: Thu, 22 Sep 2016 04:25:46 +0000
From: Riku Voipio <riku.voipio@iki.fi>
Message-ID: <20160922042546.GA25484@kos.to>
References: <1467933447-5696-1-git-send-email-laurent@vivier.eu>
	<CAFEAcA_wGCCowa3hLD02xRuE3O1YhmP=8Jk1Rgskd8hheh158Q@mail.gmail.com>
	<b24c7a7d-2505-25fe-a290-ccdaa9e220b4@vivier.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b24c7a7d-2505-25fe-a290-ccdaa9e220b4@vivier.eu>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] linux-user: fix TARGET_NR_select
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Peter Maydell <peter.maydell@linaro.org>, Timothy Pearson <tpearson@raptorengineering.com>, Allan Wirth <awirth@akamai.com>, QEMU Developers <qemu-devel@nongnu.org>

On Sun, Sep 04, 2016 at 03:49:22PM +0200, Laurent Vivier wrote:
> Le 11/07/2016 =C3=A0 18:59, Peter Maydell a =C3=A9crit :
> > On 8 July 2016 at 00:17, Laurent Vivier <laurent@vivier.eu> wrote:
> >> TARGET_NR_select can have three different implementations:
> >>
> >>   1- to always return -ENOSYS
> >>
> >>      microblaze, ppc, ppc64
> >>
> >>      -> TARGET_WANT_NI_OLD_SELECT
> >>
> >>   2- to take parameters from a structure pointed by arg1
> >>     (kernel sys_old_select)
> >>
> >>      i386, arm, m68k
> >>
> >>      -> TARGET_WANT_OLD_SYS_SELECT
> >>
> >>   3- to take parameters from arg[1-5]
> >>      (kernel sys_select)
> >>
> >>      x86_64, alpha, s390x,
> >>      cris, sparc, sparc64
> >>
> >> Some (new) architectures don't define NR_select,
> >>
> >>   4- but only NR__newselect with sys_select:
> >>
> >>       mips, mips64, sh
> >>
> >>   5- don't define NR__newselect, and use pselect6 syscall:
> >>
> >>       aarch64, openrisc, tilegx, unicore32
> >>
> >> Reported-by: Timothy Pearson <tpearson@raptorengineering.com>
> >> Reported-by: Allan Wirth <awirth@akamai.com>
> >> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> >> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> >> ---
> >=20
> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> >=20
>=20
> It seems this one has missed 2.7 window, perhaps it can queued for 2.8?

Thanks for the reminder, applied to linux-user que

Riku