From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmwuD-0001r2-4A for qemu-devel@nongnu.org; Thu, 22 Sep 2016 01:50:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmwu9-00005Q-4m for qemu-devel@nongnu.org; Thu, 22 Sep 2016 01:50:45 -0400 Date: Thu, 22 Sep 2016 15:30:08 +1000 From: David Gibson Message-ID: <20160922053008.GH2085@umbus.fritz.box> References: <20160922052105.GD7915@in.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fmEUq8M7S0s+Fl0V" Content-Disposition: inline In-Reply-To: <20160922052105.GD7915@in.ibm.com> Subject: Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, clg@kaod.org, "Nikunj A. Dadhania" --fmEUq8M7S0s+Fl0V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 22, 2016 at 10:51:05AM +0530, Bharata B Rao wrote: > Hi, >=20 > Nikunj and I realized that migrating pseries-2.6 guest from QEMU-2.6 > to newer QEMU-2.7 is broken like this: >=20 > qemu-system-ppc64: error while loading state for instance 0x0 of device '= cpu' > qemu-system-ppc64: load of migration failed: Invalid argument >=20 > Bisecting tells us that 4e0806110c8b896ceff3490f15a616e8b3165efe > (ppc: Add PPC_64H instruction flag to POWER7 and POWER8) is the > first bad commit. Along with this there are other 3 similar commits > which add new bits to insns_flags and insns_flags2 fields of POWER7 > and POWER8 CPUs. >=20 > 4e0806110c8b896ceff3490f15a616e8b3165efe Adds PPC_64H to POWER7 and POWER8 > dfdd3e43620a6cd4f2be31da5a257c84a16fc000 Adds PPC_64BX to POWER7 > b781537560e3b968b6fe1395e3d07bd67f0009ba Adds PPC_CILDST to POWER7 and PO= WER8 > 7778a575c7055276afdd01737e9d1029a65f923d Adds PPC2_PM_ISA206 to POWER7 an= d POWER8 >=20 > The flag values are expected to remain same for a machine version for > the migration to succeed, but this expectation is broken now. Should > we make the addition of these flags conditional on machine type version ? > But these flags are part of POWER8 CPU definition which is common for > both pseries and upcoming powernv. Can you step me through how the new flags are breaking the migration? It's not immediately obvious to me. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --fmEUq8M7S0s+Fl0V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX42xfAAoJEGw4ysog2bOS5WUQALlyMzs/lZYAzIC+b2oPf6eE CfP77z1ECChpHgA0WHEyzuSQsVZ00721pThfG6W+0uTliZiqA12u7la8qMix3n/m hZRnvo1Rbemy3iyoRxDNW/7KWwIsOn8FtFHAARHLQySEgMt6s9LlfbIhf/OX2VPq CeM8X4xAv7leRVYzqzfq/s6XfbfeU0f/DvPX8By+Pgk0N1FZD2Oejz36qqeAO37Z GmNmPKhqmn7qkkMCgkxn9+9c6F6aStMgok5y/nqneLbw851Lg6QpuxFnCKrB/VDC BS61Y3Ort1SXcTHlRI7gxci8ynMCaFjG9c928TDgfe1a6gNN68qR0CJzJKpDF17d 9msyqBtm8DkK07CXd0uKiOjb9TPZavprLSj15vHUDmgT+8RGwKvYb+R1171Krh6C 8PilPAoVo97P6fQdoGwR8t/XtZVqiJeMX/aY400G8CyT7HbbWQFFyGJlDfX57hZq NExOZfQXSJZniptpdce3bMnIjQk/TfTU7XB0c/vTnb6e3AflG8M4kksnJpeMBTGx iOLUP3rfRB4r0ydu+X9Gdj5oK3uyetLLdmGUPfbRfPKqcvfEi3B3aKlku1nvwZZv SAHBhvZTKS6ei/50Jb6mDSohNc+EjaFERhXTuAnGXsO93ZlwBHta/y/BR9bgucE1 Bn5FQwt5UwrN0fgzJn7+ =GJoF -----END PGP SIGNATURE----- --fmEUq8M7S0s+Fl0V--