From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48131)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <voipio@kos.to>) id 1bmxOo-0002JM-Go
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 02:22:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <voipio@kos.to>) id 1bmxOk-0001OR-9r
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 02:22:21 -0400
Received: from jessie.kos.to ([212.47.231.226]:47496 helo=pilvi.kos.to)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <voipio@kos.to>) id 1bmxOk-0001Kh-3b
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 02:22:18 -0400
Date: Thu, 22 Sep 2016 06:22:10 +0000
From: Riku Voipio <riku.voipio@iki.fi>
Message-ID: <20160922062210.GA28511@kos.to>
References: <20160918012014.GA11017@nyan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160918012014.GA11017@nyan>
Subject: Re: [Qemu-devel] [PATCH] linux-user: fix mremap for 64bit targets
 on 32bit hosts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Felix Janda <felix.janda@posteo.de>
Cc: qemu-devel@nongnu.org

Hi,

On Sat, Sep 17, 2016 at 09:20:14PM -0400, Felix Janda wrote:
> Signed-off-by: Felix Janda <felix.janda@posteo.de>

Have you run the mremap tests of ltp with this on your host/guest
combo? 

> ---
>  linux-user/mmap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> index c4371d9..4882816 100644
> --- a/linux-user/mmap.c
> +++ b/linux-user/mmap.c
> @@ -682,7 +682,7 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong old_size,
>  
>      if (flags & MREMAP_FIXED) {
>          host_addr = (void *) syscall(__NR_mremap, g2h(old_addr),
> -                                     old_size, new_size,
> +                                     (size_t) old_size, (size_t) new_size,
>                                       flags,
>                                       g2h(new_addr));
>  
> @@ -701,7 +701,7 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong old_size,
>              host_addr = MAP_FAILED;
>          } else {
>              host_addr = (void *) syscall(__NR_mremap, g2h(old_addr),
> -                                         old_size, new_size,
> +                                         (size_t) old_size, (size_t) new_size,
>                                           flags | MREMAP_FIXED,
>                                           g2h(mmap_start));
>              if (reserved_va) {
> -- 
> 2.7.3
>