From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmyvU-0007SL-Gc for qemu-devel@nongnu.org; Thu, 22 Sep 2016 04:00:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmyvQ-0001sJ-UJ for qemu-devel@nongnu.org; Thu, 22 Sep 2016 04:00:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmyvQ-0001rw-NO for qemu-devel@nongnu.org; Thu, 22 Sep 2016 04:00:08 -0400 Date: Thu, 22 Sep 2016 09:00:04 +0100 From: "Daniel P. Berrange" Message-ID: <20160922080004.GB352@redhat.com> Reply-To: "Daniel P. Berrange" References: <000301d213c7$7142f980$53c8ec80$@ru> <87y42l93dr.fsf@dusky.pond.sub.org> <20160921100718.GO15535@redhat.com> <87mvj11ljr.fsf@dusky.pond.sub.org> <7500849B-8BCC-4743-92A6-5DBD4D8575E8@nutanix.com> <20160921143546.GS15535@redhat.com> <87zin1w9v4.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Markus Armbruster , Felipe Franciosi , Pavel Dovgalyuk , qemu-devel , Pavel Dovgalyuk On Wed, Sep 21, 2016 at 01:18:58PM -0500, Eric Blake wrote: > On 09/21/2016 10:28 AM, Markus Armbruster wrote: > > >> The compiler.h file has no license header, just a comment > >> saying "public domain", which is obviously not the case > >> if you add this macro. > >> > >> Given that you'll need to explicitly mention the license terms > >> for ignore_value. eg with a comment line like > >> > >> /* The ignore_value() macro is taken from GNULIB ignore-value.h, > >> * licensed under the terms of the LGPLv2+ > >> */ > > > > Our tree has a mix of licenses, which is enough of a pain. Mixing > > licenses within *files* is even worse, and might not even be legally > > sound. > > > > Relicense the whole file under our preferred license GPLv2+? > > That works too. No one can legally complain - the current license is so > permissive that marking the entire file LGPLv2+ is permitted by the > current license. It's a one-way conversion (we can't go back once we do > it), but I would be fine with that approach. I think the file probably should not have been listed as public domain in the first place, as its initial contents were copied from qemu-common.h which is not public domain. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|