From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmxgM-0001NO-1n for qemu-devel@nongnu.org; Thu, 22 Sep 2016 02:40:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmxgI-0007Dy-Q7 for qemu-devel@nongnu.org; Thu, 22 Sep 2016 02:40:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmxgI-0007Cj-Gr for qemu-devel@nongnu.org; Thu, 22 Sep 2016 02:40:26 -0400 Date: Thu, 22 Sep 2016 08:40:20 +0200 From: Thomas Huth Message-ID: <20160922084020.12fb895a@thh440s> In-Reply-To: <1474401271-3104-1-git-send-email-rth@twiddle.net> References: <1474401271-3104-1-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/13] AVR target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org On Tue, 20 Sep 2016 12:54:31 -0700 Richard Henderson wrote: > Let us merge patch set v18. >=20 >=20 > r~ >=20 >=20 >=20 > The following changes since commit ebc231d7daf1f41b23d8b6a6d1234800b86e5f= e2: >=20 > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20160915= .0' into staging (2016-09-15 19:36:02 +0100) >=20 > are available in the git repository at: >=20 > git://github.com/rth7680/qemu.git tags/pull-avr-20160920 >=20 > for you to fetch changes up to ed250c0f1f42c06aa653d48f7f5b190972d541fe: >=20 > target-avr: Merge translate-inst.inc.c into translate.c (2016-09-16 14:= 20:20 -0700) >=20 > ---------------------------------------------------------------- > target avr >=20 > ---------------------------------------------------------------- > Michael Rolnik (9): > target-avr: AVR cores support is added. > target-avr: adding AVR CPU features/flavors > target-avr: adding a sample AVR board > target-avr: adding instructions encodings > target-avr: adding AVR interrupt handling > target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported in= structions > target-avr: adding instruction translation > target-avr: instruction decoder generator > target-avr: adding instruction decoder >=20 > Richard Henderson (4): > target-avr: Put env pointer in DisasContext > target-avr: Put all translation code into one compilation unit > target-avr: Respect .inc.c convention > target-avr: Merge translate-inst.inc.c into translate.c >=20 > MAINTAINERS | 6 + > arch_init.c | 2 + > configure | 5 + > default-configs/avr-softmmu.mak | 21 + > hw/avr/Makefile.objs | 21 + > hw/avr/sample.c | 111 ++ > include/disas/bfd.h | 6 + > include/sysemu/arch_init.h | 1 + > target-avr/Makefile.objs | 23 + > target-avr/cpu-qom.h | 84 + > target-avr/cpu.c | 602 ++++++ > target-avr/cpu.h | 237 +++ > target-avr/cpugen/CMakeLists.txt | 38 + > target-avr/cpugen/README.md | 17 + > target-avr/cpugen/cpu/avr.yaml | 213 ++ > target-avr/cpugen/src/CMakeLists.txt | 62 + > target-avr/cpugen/src/cpugen.cpp | 457 +++++ > target-avr/cpugen/src/utils.cpp | 26 + > target-avr/cpugen/src/utils.h | 78 + > target-avr/cpugen/xsl/decode.c.xsl | 103 + > target-avr/cpugen/xsl/translate-inst.h.xsl | 118 ++ > target-avr/cpugen/xsl/utils.xsl | 108 ++ > target-avr/decode.inc.c | 689 +++++++ > target-avr/gdbstub.c | 85 + > target-avr/helper.c | 355 ++++ > target-avr/helper.h | 28 + > target-avr/machine.c | 114 ++ > target-avr/translate-inst.h | 691 +++++++ > target-avr/translate.c | 2911 ++++++++++++++++++++++= ++++++ OK, this is now slightly off-topic and should not prevent your PULL request from going in, but I've got this idea since quite a while now and your PULL request triggered it again: Slowly we're getting really a lot of target-something folders in the main directory. Maybe we should rather introduce a singly "target" folder instead and put all the targets under that folder? So we then get target/avr/, target/ppc/, target/i386/ etc. in the tree instead. Would look much more tidied up to me. Our main folder is IMHO still too much overcrowded.=20 Just my 0.02 =E2=82=AC Thomas