From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmy1i-0000j0-H3 for qemu-devel@nongnu.org; Thu, 22 Sep 2016 03:02:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmy1c-0006iM-HL for qemu-devel@nongnu.org; Thu, 22 Sep 2016 03:02:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmy1c-0006iE-BJ for qemu-devel@nongnu.org; Thu, 22 Sep 2016 03:02:28 -0400 Date: Thu, 22 Sep 2016 09:02:21 +0200 From: Thomas Huth Message-ID: <20160922090221.24f4dc8a@thh440s> In-Reply-To: <775d6051-c03a-847a-2988-a07344367ea6@redhat.com> References: <1474486942-18754-1-git-send-email-thuth@redhat.com> <775d6051-c03a-847a-2988-a07344367ea6@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] scripts: Add a script to check for bug URLs in the git log List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Peter Maydell , stefanha@redhat.com On Wed, 21 Sep 2016 22:08:10 +0200 Paolo Bonzini wrote: > On 21/09/2016 21:42, Thomas Huth wrote: > > Basic idea of this script is to check the git log for URLs > > to the QEMU bugtracker at launchpad.net and to figure out > > whether the related bug has been marked there as "Fix released" > > (i.e. closed) already. So this script can e.g. be used after > > each public release of QEMU to check whether there are any > > bug tickets that could be moved from "Fix committed" (or another > > state if the author of the patch forgot to update the bug ticket) > > to "Fix released". > > > > Signed-off-by: Thomas Huth > > --- > > v3: Adressed Eric's review comments from v2 (fixed bashisms, more > > POSIX compliance, use lower-case variable names, etc.) > > Queued with this squashed in: Thanks a lot for the fixup. But... > diff --git a/scripts/show-fixed-bugs.sh b/scripts/show-fixed-bugs.sh > index 9dcc0f7..6e64edd 100755 > --- a/scripts/show-fixed-bugs.sh > +++ b/scripts/show-fixed-bugs.sh > @@ -23,7 +23,7 @@ while getopts "s:e:cbh" opt; do > done > > if [ "x$start" = "x" ]; then > - start=`git tag -l 'v[0-9]*\.[0-9]*.0' | tail -n 2 | head -n 1` > + start=`git tag -l 'v[0-9]*\.[0-9]*\.0' | tail -n 2 | head -n 1` > fi > if [ "x$end" = "x" ]; then > end=`git tag -l 'v[0-9]*\.[0-9]*.0' | tail -n 1` ... could you please also squash in another backslash in the "end=..." line here? Thanks, Thomas