From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn3Qk-0007Dv-CV for qemu-devel@nongnu.org; Thu, 22 Sep 2016 08:48:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn3Qh-0003xP-0y for qemu-devel@nongnu.org; Thu, 22 Sep 2016 08:48:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn3Qg-0003x8-R2 for qemu-devel@nongnu.org; Thu, 22 Sep 2016 08:48:42 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 68C3C3D96F for ; Thu, 22 Sep 2016 12:48:41 +0000 (UTC) Date: Thu, 22 Sep 2016 13:48:38 +0100 From: "Daniel P. Berrange" Message-ID: <20160922124838.GN352@redhat.com> Reply-To: "Daniel P. Berrange" References: <1474533652-31170-1-git-send-email-berrange@redhat.com> <1474533652-31170-12-git-send-email-berrange@redhat.com> <87fuosnlyc.fsf@fimbulvetr.bsc.es> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87fuosnlyc.fsf@fimbulvetr.bsc.es> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 11/17] trace: provide mechanism for registering trace events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Stefan Hajnoczi On Thu, Sep 22, 2016 at 02:44:11PM +0200, Llu=C3=ADs Vilanova wrote: > Daniel P Berrange writes: >=20 > > Remove the notion of there being a single global array > > of trace events, by introducing a method for registering > > groups of events. >=20 > > Signed-off-by: Daniel P. Berrange >=20 > Except for the calls to module_call_init() (I did not check if they're = all > necessary and sufficient): Every binary that can trigger tracepoints should have the module_call_ini= t(). I'd done it for emulators, qemu-img, qemu-nbd, and qemu-io. I could tell which need it, since they're the ones that need to link to the trace.o files, otherwise you'll unresolved symbol errors. So I think what I have is correct. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|