From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Max Reitz <mreitz@redhat.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/9] virtio-9p: handle handle_9p_output() error
Date: Thu, 22 Sep 2016 15:41:46 +0200 [thread overview]
Message-ID: <20160922154146.51932cd7.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <147447703245.30952.11628276217402153393.stgit@bahia>
On Wed, 21 Sep 2016 18:57:12 +0200
Greg Kurz <groug@kaod.org> wrote:
> A broken guest may send a request with only non-empty out buffers
> or only non-empty in buffers, virtqueue_pop() will then return a
> VirtQueueElement with out_num == 0 or in_num == 0 respectively.
>
> All 9P requests are expected to start with the following 7-byte header:
>
> uint32_t size_le;
> uint8_t id;
> uint16_t tag_le;
>
> If iov_to_buf() fails to return these 7 bytes, then something is wrong in
> the guest.
>
> In both cases, it is wrong to crash QEMU, since the root cause lies in the
> guest. Let's switch the device to the broken state instead.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> v2: - added out_free_pdu: label for errors or when virtqueue is empty
> ---
> hw/9pfs/virtio-9p-device.c | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2016-09-22 13:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 16:56 [Qemu-devel] [PATCH v2 0/9] virtio: avoid inappropriate QEMU termination Greg Kurz
2016-09-21 16:56 ` [Qemu-devel] [PATCH v2 1/9] virtio-9p: add parentheses to sizeof operator Greg Kurz
2016-09-22 13:38 ` Cornelia Huck
2016-09-23 12:44 ` Stefan Hajnoczi
2016-09-21 16:57 ` [Qemu-devel] [PATCH v2 2/9] virtio-blk: turn virtio_blk_handle_request() into a static function Greg Kurz
2016-09-22 13:40 ` Cornelia Huck
2016-09-23 12:45 ` Stefan Hajnoczi
2016-09-21 16:57 ` [Qemu-devel] [PATCH v2 3/9] virtio-9p: handle handle_9p_output() error Greg Kurz
2016-09-22 13:41 ` Cornelia Huck [this message]
2016-09-23 12:54 ` Stefan Hajnoczi
2016-09-23 13:49 ` Greg Kurz
2016-09-21 16:57 ` [Qemu-devel] [PATCH v2 4/9] virtio-blk: handle virtio_blk_handle_request() errors Greg Kurz
2016-09-22 13:44 ` Cornelia Huck
2016-09-23 12:58 ` Stefan Hajnoczi
2016-09-24 18:01 ` Greg Kurz
2016-09-21 16:57 ` [Qemu-devel] [PATCH v2 5/9] virtio-net: handle virtio_net_handle_ctrl() error Greg Kurz
2016-09-22 13:45 ` Cornelia Huck
2016-09-23 13:07 ` Stefan Hajnoczi
2016-09-21 16:57 ` [Qemu-devel] [PATCH v2 6/9] virtio-net: handle virtio_net_receive() errors Greg Kurz
2016-09-23 13:11 ` Stefan Hajnoczi
2016-09-21 16:57 ` [Qemu-devel] [PATCH v2 7/9] virtio-net: handle virtio_net_flush_tx() errors Greg Kurz
2016-09-21 16:57 ` [Qemu-devel] [PATCH v2 8/9] virtio-scsi: convert virtio_scsi_bad_req() to use virtio_error() Greg Kurz
2016-09-21 16:58 ` [Qemu-devel] [PATCH v2 9/9] virtio-scsi: handle virtio_scsi_set_config() error Greg Kurz
2016-09-21 17:50 ` [Qemu-devel] [PATCH v2 0/9] virtio: avoid inappropriate QEMU termination no-reply
2016-09-22 13:47 ` Cornelia Huck
2016-09-23 13:31 ` Stefan Hajnoczi
2016-09-23 14:00 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922154146.51932cd7.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=groug@kaod.org \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).