From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn4LO-0006rZ-Mj for qemu-devel@nongnu.org; Thu, 22 Sep 2016 09:47:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn4LJ-0000dF-KJ for qemu-devel@nongnu.org; Thu, 22 Sep 2016 09:47:17 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn4LJ-0000cR-Au for qemu-devel@nongnu.org; Thu, 22 Sep 2016 09:47:13 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8MDhH3O136765 for ; Thu, 22 Sep 2016 09:47:12 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 25mcrrp6q3-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 22 Sep 2016 09:47:12 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 22 Sep 2016 14:47:10 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 668E017D8068 for ; Thu, 22 Sep 2016 14:49:07 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8MDl7xK63307984 for ; Thu, 22 Sep 2016 13:47:07 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u8MDl6ea023263 for ; Thu, 22 Sep 2016 07:47:07 -0600 Date: Thu, 22 Sep 2016 15:47:04 +0200 From: Cornelia Huck In-Reply-To: <147447700612.30952.9420141963781948805.stgit@bahia> References: <147447700612.30952.9420141963781948805.stgit@bahia> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20160922154704.01925d96.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 0/9] virtio: avoid inappropriate QEMU termination List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: qemu-devel@nongnu.org, Kevin Wolf , "Michael S. Tsirkin" , Jason Wang , Max Reitz , "Aneesh Kumar K.V" , Stefan Hajnoczi , Paolo Bonzini On Wed, 21 Sep 2016 18:56:46 +0200 Greg Kurz wrote: > This series is a follow up to Stefan's work to eradicate most calls to > exit() we currently have in the virtio code. > > It addresses all exit() call sites in the blk, net and scsi device code, > where the error is about a missing or malformed in/out header sent by > the guest. They are converted to use virtio_error() and stop any processing, > instead of exiting. > > The remaining call sites are related to a host misconfiguration or a > migration stream issue. > > The 9P code currently calls assert() instead of exit(), but it also about > malformed or missing headers, so it gets converted the same way. > > Next work will be to check all assert() call sites in the device code, in > case some of them actually refer to a bug in the guest, and should be > converted to use virtio_error() as well. I'm nearly out of the door for my vacation, so don't wait for any further R-b from me :)