From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnGXq-0001dD-R8 for qemu-devel@nongnu.org; Thu, 22 Sep 2016 22:49:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnGXo-0002F8-Ki for qemu-devel@nongnu.org; Thu, 22 Sep 2016 22:48:57 -0400 Received: from ozlabs.org ([103.22.144.67]:57992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnGXo-0002E5-6Z for qemu-devel@nongnu.org; Thu, 22 Sep 2016 22:48:56 -0400 Date: Fri, 23 Sep 2016 10:35:29 +1000 From: David Gibson Message-ID: <20160923003529.GI2085@umbus.fritz.box> References: <1474433936-19617-1-git-send-email-peterx@redhat.com> <1474433936-19617-4-git-send-email-peterx@redhat.com> <20160922052443.GG2085@umbus.fritz.box> <20160922055538.GO5134@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pe+tqlI1iYzVj1X/" Content-Disposition: inline In-Reply-To: <20160922055538.GO5134@pxdev.xzpeter.org> Subject: Re: [Qemu-devel] [PATCH v6 3/3] intel_iommu: allow UNMAP notifiers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, mst@redhat.com, jasowang@redhat.com, vkaplans@redhat.com, alex.williamson@redhat.com, wexu@redhat.com, pbonzini@redhat.com, cornelia.huck@de.ibm.com, dgibson@redhat.com --pe+tqlI1iYzVj1X/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 22, 2016 at 01:55:38PM +0800, Peter Xu wrote: > On Thu, Sep 22, 2016 at 03:24:43PM +1000, David Gibson wrote: > > On Wed, Sep 21, 2016 at 12:58:56PM +0800, Peter Xu wrote: > > > Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. > > > Before that is achieved, let's open a door for vhost DMAR support, wh= ich > > > only requires cache invalidations (UNMAP operations). > > >=20 > > > Meanwhile, converting hw_error() to error_report() and exit(1), to ma= ke > > > the error messages clean and obvious (so no CPU registers will be > > > dumped). > > >=20 > > > Reviewed-by: David Gibson > >=20 > > Uh.. I didn't send an R-b for this. In fact I explicitly said I > > didn't think it should be applied until notifications have actually > > been implemented by the intel viommu. I still think that, and think > > this should just be dropped. >=20 > Please refer to: >=20 > https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg03034.html >=20 > So this line is there since v5. >=20 > I took it an honor (and also with my thankfulness) to have added your > r-b line here. I assume what you meant before was: the patch content > is okay, but you would suggest to drop this patch in this series, and > merge this until we got a real implementations for the notifiers. IMHO > that does not mean "remove your r-b in this patch". If you meant to > remove this line (I think not?), please confirm and I can remove it. Fair enough. Sorry for my crabbiness. > I posted patch 3 just to make sure everything is coherent, and let > Paolo decide which way to choose (since I still think it's okay > actually... but again both are ok to me). Also it'll be easier for > Jason to track this down as well (so when Jason sees that Paolo > dropped patch 3, he'll naturally pick it up). If you still insist on > dropping this patch, I'll do it in v7. >=20 > Thanks. >=20 > -- peterx >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --pe+tqlI1iYzVj1X/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX5HjOAAoJEGw4ysog2bOSXFUP/Asy54IjqfFtmFqY36wYjIwD IZbLO+BV1RSZm864lE/rQ8OCd3l1D4UR74BVbA/dxCBtLbO8CQHoBZgwc2aqk71F kicSPRVTPoLlmEpKRNdgIxBXKIjY5LBnlLP+xc7JdXY+IOKXhRb1rEsfgcfmj/7O O+I4CjdkPc2r3fLszuACUEXqnenT2JZdbH5zlsL5oDGCTjLVskVCVnefOtvTV+jX ofT7dRNKpheiGVd1TUCSKt1YC/EYQ3NO+G2OU9PzeuTatI2rFVef/7e/+SHIgoIt moLG4rwJtUmjv4InCgfZa05uK8APhlDgW1LvGUjrjeNCRSg3WITG8fyUGo+1w2J7 lMU80QAryCHwZHaGfV4Rc3cvrTUk7RB4CJh3c22AB5WoxWoTtn9RP1yxiywbugCY KyCauBWmPsj8smdFmA1AOVkDTAmu8H7fEprrYzsTR+b21oujSUXINZ1ssJr2xklX 2i4sDZnxyjjZUNHjHMLynlrQHOck8tU0177ZEqAOcCVteyFnAGoySEqR81rNPA9N IDJoGUS3NW773/9MLbWabqCfC0X1tOCWpT1D9TC+DXwSkax2zFawdz2Oq+/YHPYz 8xWx/lt0/BceQsaYBl2vRTnqBVlnthNy2bkMDBx/c7tVqCuLvzt1SfFapRY0jZJH Xp4KGhRIvSoxC9NAxhhK =g54E -----END PGP SIGNATURE----- --pe+tqlI1iYzVj1X/--