From: Fam Zheng <famz@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-block@nongnu.org, kwolf@redhat.com, mreitz@redhat.com,
qemu-stable@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 0/3] block: allow flush on devices with open tray
Date: Fri, 23 Sep 2016 12:11:02 +0800 [thread overview]
Message-ID: <20160923041102.GC8832@lemon> (raw)
In-Reply-To: <1474595152-4383-1-git-send-email-jsnow@redhat.com>
On Thu, 09/22 21:45, John Snow wrote:
> When I said "Final re-send," I was lying. Here's a v5.
> The title is also a misnomer by now :)
>
> The move to blk_flush altered the behavior of migration and flushing
> nodes that are not reachable via the guest, but are still reachable
> via QEMU and may or may not need to be flushed.
>
> This is intended for 2.6.2 and/or 2.7.1, to fix problems with libvirt
> et al being unable to migrate QEMU when the CDROM tray is open.
>
> v5:
> Fix bracket spacing in patch 1. By one space. :(
> Added third patch to remove blk_flush_all.
>
> v4:
> Commit message update.
>
> v3:
> Reworking approach and reinstating bdrv_flush_all at Kevin's suggestion.
>
> ________________________________________________________________________________
>
> For convenience, this branch is available at:
> https://github.com/jnsnow/qemu.git branch atapi-tray-migfix
> https://github.com/jnsnow/qemu/tree/atapi-tray-migfix
>
> This version is tagged atapi-tray-migfix-v5:
> https://github.com/jnsnow/qemu/releases/tag/atapi-tray-migfix-v5
>
> John Snow (3):
> block: reintroduce bdrv_flush_all
> qemu: use bdrv_flush_all for vm_stop et al
> block-backend: remove blk_flush_all
>
> block/block-backend.c | 22 ----------------------
> block/io.c | 25 +++++++++++++++++++++++++
> cpus.c | 4 ++--
> hw/i386/xen/xen_platform.c | 2 --
> hw/ide/piix.c | 4 ++++
> include/block/block.h | 1 +
> include/sysemu/block-backend.h | 1 -
> 7 files changed, 32 insertions(+), 27 deletions(-)
>
> --
> 2.7.4
>
>
Acked-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2016-09-23 4:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 1:45 [Qemu-devel] [PATCH v5 0/3] block: allow flush on devices with open tray John Snow
2016-09-23 1:45 ` [Qemu-devel] [PATCH v5 1/3] block: reintroduce bdrv_flush_all John Snow
2016-09-23 1:45 ` [Qemu-devel] [PATCH v5 2/3] qemu: use bdrv_flush_all for vm_stop et al John Snow
2016-09-23 1:45 ` [Qemu-devel] [PATCH v5 3/3] block-backend: remove blk_flush_all John Snow
2016-09-23 4:11 ` Fam Zheng [this message]
2016-09-23 15:35 ` [Qemu-devel] [PATCH v5 0/3] block: allow flush on devices with open tray Max Reitz
2016-09-23 19:38 ` John Snow
2016-09-26 8:28 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923041102.GC8832@lemon \
--to=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).