From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37344)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1bnMz5-0005H5-Gt
	for qemu-devel@nongnu.org; Fri, 23 Sep 2016 05:41:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1bnMz2-0003if-Bg
	for qemu-devel@nongnu.org; Fri, 23 Sep 2016 05:41:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45072)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1bnMz2-0003iW-5I
	for qemu-devel@nongnu.org; Fri, 23 Sep 2016 05:41:28 -0400
Date: Fri, 23 Sep 2016 17:41:22 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20160923094122.GC29144@pxdev.xzpeter.org>
References: <20160922210432.18680-1-rkrcmar@redhat.com>
	<20160922210432.18680-4-rkrcmar@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160922210432.18680-4-rkrcmar@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 3/5] intel_iommu: pass whole remapped
 addresses to apic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Cc: qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

On Thu, Sep 22, 2016 at 11:04:30PM +0200, Radim Kr=C4=8Dm=C3=A1=C5=99 wro=
te:

[...]

> @@ -279,18 +280,16 @@ static void vtd_update_iotlb(IntelIOMMUState *s, =
uint16_t source_id,
>  static void vtd_generate_interrupt(IntelIOMMUState *s, hwaddr mesg_add=
r_reg,
>                                     hwaddr mesg_data_reg)
>  {
> -    hwaddr addr;
> -    uint32_t data;
> +    MSIMessage msi;
> =20
>      assert(mesg_data_reg < DMAR_REG_SIZE);
>      assert(mesg_addr_reg < DMAR_REG_SIZE);
> =20
> -    addr =3D vtd_get_long_raw(s, mesg_addr_reg);
> -    data =3D vtd_get_long_raw(s, mesg_data_reg);
> +    msi.address =3D vtd_get_long_raw(s, mesg_addr_reg);
> +    msi.data =3D vtd_get_long_raw(s, mesg_data_reg);
> =20
>      VTD_DPRINTF(FLOG, "msi: addr 0x%"PRIx64 " data 0x%"PRIx32, addr, d=
ata);

Need to fix addr/data as well?

-- peterx