From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnO69-00019H-NM for qemu-devel@nongnu.org; Fri, 23 Sep 2016 06:52:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnO63-0003kO-MA for qemu-devel@nongnu.org; Fri, 23 Sep 2016 06:52:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnO63-0003kA-G3 for qemu-devel@nongnu.org; Fri, 23 Sep 2016 06:52:47 -0400 Date: Fri, 23 Sep 2016 18:52:37 +0800 From: Peter Xu Message-ID: <20160923105237.GF29144@pxdev.xzpeter.org> References: <20160922210432.18680-1-rkrcmar@redhat.com> <20160922210432.18680-6-rkrcmar@redhat.com> <20160923100207.GD29144@pxdev.xzpeter.org> <20160923101213.GE29144@pxdev.xzpeter.org> <76b2b248-d9bc-5a4e-e2fd-aa4fd665005b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <76b2b248-d9bc-5a4e-e2fd-aa4fd665005b@redhat.com> Subject: Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Radim =?utf-8?B?S3LEjW3DocWZ?= , qemu-devel@nongnu.org, Igor Mammedov , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" On Fri, Sep 23, 2016 at 12:39:19PM +0200, Paolo Bonzini wrote: > > > On 23/09/2016 12:12, Peter Xu wrote: > > On Fri, Sep 23, 2016 at 12:03:26PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 23/09/2016 12:02, Peter Xu wrote: > >>> On Fri, Sep 23, 2016 at 11:27:09AM +0200, Paolo Bonzini wrote: > >>>>> Since the whole IOMMU feature is new and somewhat experimental, I think > >>>>> it's okay to just make EIM the default for >=2.8 machine types if KVM is > >>>>> on (using DEFINE_PROP_ON_OFF_AUTO; auto means true if KVM is on and > >>>>> false otherwise, and pc-2.7 would set eim=off). It means requiring > >>>>> kernel 4.8 by default, but I don't think it's a big deal. > >>> I think the problem is, even we have KVM support for x2apic, we are > >>> still losing QEMU part. And guests with cluster x2apic and >8 vcpus > >>> will not working properly on device interrupts, which can be very > >>> confusing to people (it can boot, but some devices just don't work > >>> properly, and they won't see useful information in guest dmesg). > >> > >> Yes, that's why I suggested EIM=on by default. > > > > I am confused. :( > > > > Why not we just keep people from that wrong configuration by default, > > until we have x2apic in QEMU? > > Do you mean Igor's patches? I expect that they will go in pretty much > at the same time as Radim's. Ah! Yes we have x2apic all here... So I totally agree we should set it on as default. (My mistake of not noticing the truth) Thanks, -- peterx