From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnQuz-0001Ek-Uq for qemu-devel@nongnu.org; Fri, 23 Sep 2016 09:53:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnQuu-0005pE-7g for qemu-devel@nongnu.org; Fri, 23 Sep 2016 09:53:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54424) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnQuu-0005oV-0o for qemu-devel@nongnu.org; Fri, 23 Sep 2016 09:53:28 -0400 Date: Fri, 23 Sep 2016 14:53:25 +0100 From: Stefan Hajnoczi Message-ID: <20160923135325.GT8221@stefanha-x1.localdomain> References: <1474533652-31170-1-git-send-email-berrange@redhat.com> <1474533652-31170-7-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PLOb/g6AMdJ1vPHZ" Content-Disposition: inline In-Reply-To: <1474533652-31170-7-git-send-email-berrange@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 06/17] trace: break circular dependency in event-internal.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, =?iso-8859-1?Q?Llu=EDs?= Vilanova , Eric Blake --PLOb/g6AMdJ1vPHZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 22, 2016 at 09:40:41AM +0100, Daniel P. Berrange wrote: > Currently event-internal.h includes generated-events.h, > while generated-events.h includes event-internal.h > causing a circular dependency. >=20 > event-internal.h requires that the content of > generated-events.h comes first, so that it can see > the typedefs for TraceEventID and TraceEventVCPUID. >=20 > Switching the TraceEvent struct to use uint32_t > for the two ID fields, removes the dependency on > the typedef, allowing events-internal.h to be a > self-contained header. This will then let the patch > following this move event-internal.h to the top of > generated-events.h, so we can expose TraceEvent > struct variables in generated-events.h >=20 > Signed-off-by: Daniel P. Berrange > --- > trace/event-internal.h | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Stefan Hajnoczi --PLOb/g6AMdJ1vPHZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJX5TPVAAoJEJykq7OBq3PILAIH/jIhOkj7aNFuKdnjD0OfTdyN 8qEk3+XtCSjoWQ6xd8oY7UHKY3R2g1XHxME9+7yUGISamk+33C7A3foAxNt8g0lz Hs+FHMjBQea/Uhqpi2IA09dKh2XRl8rTlMhn61gXICJpGvsN5rFuFHb0gnCkYOgk JbzS06s5lmUpXG13kfpmPxr1mVB8GYdopa2fqaW1jCNjUvrBZM4kt9/lbqtmbBFd eZGj8GPuh4amvlsxeydsed65zucgl8PifV1h4XfQ4Ca+g7yfB3J1K3KEA9H0Kv8w gwwR6tvO28q1p4Ex+ijiUDMhzmaQgQCyds/KKR9c9bBCqY8O1YrAUld6xHA48DM= =75Nj -----END PGP SIGNATURE----- --PLOb/g6AMdJ1vPHZ--