From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41879)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1bnTdz-0000s8-Eu
	for qemu-devel@nongnu.org; Fri, 23 Sep 2016 12:48:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1bnTdu-0004sO-F7
	for qemu-devel@nongnu.org; Fri, 23 Sep 2016 12:48:10 -0400
Received: from mail-wm0-f68.google.com ([74.125.82.68]:35365)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1bnTdu-0004s7-8k
	for qemu-devel@nongnu.org; Fri, 23 Sep 2016 12:48:06 -0400
Received: by mail-wm0-f68.google.com with SMTP id 133so3660735wmq.2
	for <qemu-devel@nongnu.org>; Fri, 23 Sep 2016 09:48:05 -0700 (PDT)
Date: Fri, 23 Sep 2016 18:45:29 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20160923164529.GV16305@toto>
References: <1474644551-5819-1-git-send-email-rth@twiddle.net>
	<1474644551-5819-2-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1474644551-5819-2-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 2/4] target-microblaze: Do not dump cpu
 state with -d in_asm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Fri, Sep 23, 2016 at 08:29:09AM -0700, Richard Henderson wrote:
> Dumping cpu state is what -d cpu is for.
>

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>


> Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  target-microblaze/translate.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c
> index 80098ec..5a4a8b9 100644
> --- a/target-microblaze/translate.c
> +++ b/target-microblaze/translate.c
> @@ -1670,13 +1670,6 @@ void gen_intermediate_code(CPUMBState *env, struct TranslationBlock *tb)
>          cpu_abort(cs, "Microblaze: unaligned PC=%x\n", pc_start);
>      }
>  
> -    if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)) {
> -#if !SIM_COMPAT
> -        qemu_log("--------------\n");
> -        log_cpu_state(CPU(cpu), 0);
> -#endif
> -    }
> -
>      next_page_start = (pc_start & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE;
>      num_insns = 0;
>      max_insns = tb->cflags & CF_COUNT_MASK;
> @@ -1820,7 +1813,7 @@ void gen_intermediate_code(CPUMBState *env, struct TranslationBlock *tb)
>  #if !SIM_COMPAT
>      if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)
>          && qemu_log_in_addr_range(pc_start)) {
> -        qemu_log("\n");
> +        qemu_log("--------------\n");
>  #if DISAS_GNU
>          log_target_disas(cs, pc_start, dc->pc - pc_start, 0);
>  #endif
> -- 
> 2.7.4
>