From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34800)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1boAuP-0002rX-1o
	for qemu-devel@nongnu.org; Sun, 25 Sep 2016 11:00:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1boAuK-0003gx-PT
	for qemu-devel@nongnu.org; Sun, 25 Sep 2016 11:00:00 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:33127)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1boAuK-0003gn-JE
	for qemu-devel@nongnu.org; Sun, 25 Sep 2016 10:59:56 -0400
Received: by mail-wm0-f67.google.com with SMTP id w84so10274713wmg.0
	for <qemu-devel@nongnu.org>; Sun, 25 Sep 2016 07:59:56 -0700 (PDT)
Date: Sun, 25 Sep 2016 16:58:53 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20160925145853.GB5931@toto>
References: <20160822161740.4252-1-prem.mallappa@broadcom.com>
	<20160822161740.4252-2-prem.mallappa@broadcom.com>
	<3c8edc1c-fd1a-7da6-9274-ad4191eddbdc@redhat.com>
	<CAFCmjp8xZAh1iKup7bC6qcg_Lf9g6+rRgCKWy_wLcutbz17mLQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFCmjp8xZAh1iKup7bC6qcg_Lf9g6+rRgCKWy_wLcutbz17mLQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/9] log: Add new IOMMU type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Prem Mallappa <prem.mallappa@broadcom.com>
Cc: Auger Eric <eric.auger@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>

On Tue, Sep 13, 2016 at 01:53:39AM +0530, Prem Mallappa wrote:
> On Fri, Sep 9, 2016 at 9:06 PM, Auger Eric <eric.auger@redhat.com> wrote:
> 
> > Hi Prem,
> >
> > Missing commit message
> >
> > > Signed-off-by: Prem Mallappa <prem.mallappa@broadcom.com>
> > > ---
> > >  include/qemu/log.h | 1 +
> > >  util/log.c         | 2 ++
> > >  2 files changed, 3 insertions(+)
> > >
> > > diff --git a/include/qemu/log.h b/include/qemu/log.h
> > > index 234fa81..3dd2131 100644
> > > --- a/include/qemu/log.h
> > > +++ b/include/qemu/log.h
> > > @@ -42,6 +42,7 @@ static inline bool qemu_log_separate(void)
> > >  #define CPU_LOG_TB_NOCHAIN (1 << 13)
> > >  #define CPU_LOG_PAGE       (1 << 14)
> > >  #define LOG_TRACE          (1 << 15)
> > > +#define CPU_LOG_IOMMU      (1 << 16)
> > why is it prefixed with CPU_ ?
> > besides all arm gic devices seem to use LOG_GUEST_ERROR. what is the
> > rationale behind introducing a new enum?
> >
> 
> Will change this to LOG_GUEST_ERROR, if others on the list are okay.

Hi,

LOG_GUEST_ERROR is used for cases when the guest programs things in bad
way. E.g sets up a register in an invalid manner or writes to regs that
don't exist.

In this case we're logging information for valid translation steps, I
would prefer if we could use something else than LOG_GUEST_ERROR.
An IOMMU logging class sounds good to me.

Best regards,
Edgar