* [Qemu-devel] [PATCH] MAINTAINERS: Add some more headers to the IDE section
@ 2016-09-23 16:09 Thomas Huth
2016-09-23 16:42 ` John Snow
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2016-09-23 16:09 UTC (permalink / raw)
To: John Snow, qemu-devel; +Cc: qemu-trivial, qemu-block
The folder include/hw/ide/ belongs to the IDE section.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index d8a0cfc..acf6d6c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -791,6 +791,7 @@ M: John Snow <jsnow@redhat.com>
L: qemu-block@nongnu.org
S: Supported
F: include/hw/ide.h
+F: include/hw/ide/
F: hw/ide/
F: hw/block/block.c
F: hw/block/cdrom.c
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some more headers to the IDE section
2016-09-23 16:09 [Qemu-devel] [PATCH] MAINTAINERS: Add some more headers to the IDE section Thomas Huth
@ 2016-09-23 16:42 ` John Snow
2016-09-26 8:22 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
0 siblings, 1 reply; 6+ messages in thread
From: John Snow @ 2016-09-23 16:42 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: qemu-trivial, qemu-block
On 09/23/2016 12:09 PM, Thomas Huth wrote:
> The folder include/hw/ide/ belongs to the IDE section.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d8a0cfc..acf6d6c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -791,6 +791,7 @@ M: John Snow <jsnow@redhat.com>
> L: qemu-block@nongnu.org
> S: Supported
> F: include/hw/ide.h
> +F: include/hw/ide/
> F: hw/ide/
> F: hw/block/block.c
> F: hw/block/cdrom.c
>
Ah, yeah. These got missed when they were moved over. Thanks.
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] MAINTAINERS: Add some more headers to the IDE section
2016-09-23 16:42 ` John Snow
@ 2016-09-26 8:22 ` Kevin Wolf
2016-09-26 9:39 ` Thomas Huth
0 siblings, 1 reply; 6+ messages in thread
From: Kevin Wolf @ 2016-09-26 8:22 UTC (permalink / raw)
To: John Snow; +Cc: Thomas Huth, qemu-devel, qemu-trivial, qemu-block
Am 23.09.2016 um 18:42 hat John Snow geschrieben:
> On 09/23/2016 12:09 PM, Thomas Huth wrote:
> >The folder include/hw/ide/ belongs to the IDE section.
> >
> >Signed-off-by: Thomas Huth <thuth@redhat.com>
> >---
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/MAINTAINERS b/MAINTAINERS
> >index d8a0cfc..acf6d6c 100644
> >--- a/MAINTAINERS
> >+++ b/MAINTAINERS
> >@@ -791,6 +791,7 @@ M: John Snow <jsnow@redhat.com>
> > L: qemu-block@nongnu.org
> > S: Supported
> > F: include/hw/ide.h
> >+F: include/hw/ide/
> > F: hw/ide/
> > F: hw/block/block.c
> > F: hw/block/cdrom.c
> >
>
> Ah, yeah. These got missed when they were moved over. Thanks.
>
> Reviewed-by: John Snow <jsnow@redhat.com>
Who is supposed to merge this if you only give an R-b?
And didn't we want to move the internal header files back to hw/ instead
of the global include directory?
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] MAINTAINERS: Add some more headers to the IDE section
2016-09-26 8:22 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
@ 2016-09-26 9:39 ` Thomas Huth
2016-09-26 15:21 ` John Snow
2016-09-26 19:00 ` John Snow
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Huth @ 2016-09-26 9:39 UTC (permalink / raw)
To: Kevin Wolf, John Snow; +Cc: qemu-trivial, qemu-devel, qemu-block
[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]
On 26.09.2016 10:22, Kevin Wolf wrote:
> Am 23.09.2016 um 18:42 hat John Snow geschrieben:
>> On 09/23/2016 12:09 PM, Thomas Huth wrote:
>>> The folder include/hw/ide/ belongs to the IDE section.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>> MAINTAINERS | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index d8a0cfc..acf6d6c 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -791,6 +791,7 @@ M: John Snow <jsnow@redhat.com>
>>> L: qemu-block@nongnu.org
>>> S: Supported
>>> F: include/hw/ide.h
>>> +F: include/hw/ide/
>>> F: hw/ide/
>>> F: hw/block/block.c
>>> F: hw/block/cdrom.c
>>>
>>
>> Ah, yeah. These got missed when they were moved over. Thanks.
>>
>> Reviewed-by: John Snow <jsnow@redhat.com>
>
> Who is supposed to merge this if you only give an R-b?
I've CC:ed this patch to qemu-trivial, so I hope it will get picked up
there if John does not want to apply this directly.
Thomas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] MAINTAINERS: Add some more headers to the IDE section
2016-09-26 9:39 ` Thomas Huth
@ 2016-09-26 15:21 ` John Snow
2016-09-26 19:00 ` John Snow
1 sibling, 0 replies; 6+ messages in thread
From: John Snow @ 2016-09-26 15:21 UTC (permalink / raw)
To: Thomas Huth, Kevin Wolf; +Cc: qemu-trivial, qemu-devel, qemu-block
On 09/26/2016 05:39 AM, Thomas Huth wrote:
> On 26.09.2016 10:22, Kevin Wolf wrote:
>> Am 23.09.2016 um 18:42 hat John Snow geschrieben:
>>> On 09/23/2016 12:09 PM, Thomas Huth wrote:
>>>> The folder include/hw/ide/ belongs to the IDE section.
>>>>
>>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>>> ---
>>>> MAINTAINERS | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index d8a0cfc..acf6d6c 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -791,6 +791,7 @@ M: John Snow <jsnow@redhat.com>
>>>> L: qemu-block@nongnu.org
>>>> S: Supported
>>>> F: include/hw/ide.h
>>>> +F: include/hw/ide/
>>>> F: hw/ide/
>>>> F: hw/block/block.c
>>>> F: hw/block/cdrom.c
>>>>
>>>
>>> Ah, yeah. These got missed when they were moved over. Thanks.
>>>
>>> Reviewed-by: John Snow <jsnow@redhat.com>
>>
>> Who is supposed to merge this if you only give an R-b?
>
> I've CC:ed this patch to qemu-trivial, so I hope it will get picked up
> there if John does not want to apply this directly.
>
> Thomas
>
>
Sorry, I didn't realize I would be expected to merge this myself.
And I do want to move the files back, but I have to disentangle them and
haven't done so yet. In the meantime, they should be recorded in
MAINTAINERS.
I'll stage this page in my IDE branch, thanks
--js
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] MAINTAINERS: Add some more headers to the IDE section
2016-09-26 9:39 ` Thomas Huth
2016-09-26 15:21 ` John Snow
@ 2016-09-26 19:00 ` John Snow
1 sibling, 0 replies; 6+ messages in thread
From: John Snow @ 2016-09-26 19:00 UTC (permalink / raw)
To: Thomas Huth, Kevin Wolf; +Cc: qemu-trivial, qemu-devel, qemu-block
On 09/26/2016 05:39 AM, Thomas Huth wrote:
> On 26.09.2016 10:22, Kevin Wolf wrote:
>> Am 23.09.2016 um 18:42 hat John Snow geschrieben:
>>> On 09/23/2016 12:09 PM, Thomas Huth wrote:
>>>> The folder include/hw/ide/ belongs to the IDE section.
>>>>
>>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>>> ---
>>>> MAINTAINERS | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index d8a0cfc..acf6d6c 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -791,6 +791,7 @@ M: John Snow <jsnow@redhat.com>
>>>> L: qemu-block@nongnu.org
>>>> S: Supported
>>>> F: include/hw/ide.h
>>>> +F: include/hw/ide/
>>>> F: hw/ide/
>>>> F: hw/block/block.c
>>>> F: hw/block/cdrom.c
>>>>
>>>
>>> Ah, yeah. These got missed when they were moved over. Thanks.
>>>
>>> Reviewed-by: John Snow <jsnow@redhat.com>
>>
>> Who is supposed to merge this if you only give an R-b?
>
> I've CC:ed this patch to qemu-trivial, so I hope it will get picked up
> there if John does not want to apply this directly.
>
> Thomas
>
>
Thanks, applied to my IDE tree:
https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git
--js
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-26 19:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-23 16:09 [Qemu-devel] [PATCH] MAINTAINERS: Add some more headers to the IDE section Thomas Huth
2016-09-23 16:42 ` John Snow
2016-09-26 8:22 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2016-09-26 9:39 ` Thomas Huth
2016-09-26 15:21 ` John Snow
2016-09-26 19:00 ` John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).