From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boS1r-0006p9-8i for qemu-devel@nongnu.org; Mon, 26 Sep 2016 05:16:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boS1q-0006XH-Be for qemu-devel@nongnu.org; Mon, 26 Sep 2016 05:16:51 -0400 Date: Mon, 26 Sep 2016 11:16:45 +0200 From: Kevin Wolf Message-ID: <20160926091645.GD6093@noname.str.redhat.com> References: <1474641161-10891-1-git-send-email-kwolf@redhat.com> <1474641161-10891-4-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 3/7] block/qapi: Move 'aio' option to file driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-block@nongnu.org, mreitz@redhat.com, qemu-devel@nongnu.org --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 23.09.2016 um 16:40 hat Eric Blake geschrieben: > On 09/23/2016 09:32 AM, Kevin Wolf wrote: > > The option whether or not to use a native AIO interface really isn't a > > generic option for all drivers, but only applies to the native file > > protocols. This patch moves the option in blockdev-add to the > > appropriate places (raw-posix and raw-win32). > >=20 > > We still have to keep the flag BDRV_O_NATIVE_AIO for compatibility > > because so far the AIO option was usually specified on the wrong layer > > (the top-level format driver, which didn't even look at it) and then > > inherited by the protocol driver (where it was actually used). We can't > > forbid this use except in new interfaces. > >=20 > > Signed-off-by: Kevin Wolf > > --- > > block/raw-posix.c | 44 ++++++++++++++++++++++++--------------- > > block/raw-win32.c | 56 ++++++++++++++++++++++++++++++++++++++++++= +++----- > > qapi/block-core.json | 6 +++--- > > tests/qemu-iotests/087 | 4 ++-- > > 4 files changed, 83 insertions(+), 27 deletions(-) > >=20 >=20 > > +++ b/qapi/block-core.json > > @@ -1724,11 +1724,13 @@ > > # Driver specific block device options for the file backend. > > # > > # @filename: path to the image file > > +# @aio: #optional AIO backend (default: threads) >=20 > Missed this last time, but probably worth a '(since 2.8)' marker. I'm not sure how useful this is when the whole blockdev-add command is still experimental and we're going to break it incompatibly by removing the "options" layer. But we have the annotation elsewhere, so I'll add it. Maybe the patch that breaks compatibility should remove the annotation everywhere again. Kevin --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJX6Od9AAoJEH8JsnLIjy/WGU8P/1+uB16CDNFwf9VHrmNBjGDZ drLy8cdULKChJ5cr0DjeI+yrJyK8q7U3UIsTea0fTQPKW2YwnLXNoTISu66iZQ5D rXivkbFKXyaB3ltvs2R3PE1nKcB0dUAugu32aTafBH2kOZR6RMNk+fPXoxL9vCIN FIp2KCnyBFx4BTzCJcYCWg0/f2MOIqFvY9Bdhfynrcyt601rS6XH+aoFrOb1X8p0 Q6zX5W3yqOmBlBTfdCoUOjbkViLsh88IhAZoO32y8vr/vWeP0K2YHGL/hKHvVC76 Bv390XYttcaNJQ3jmoQtH2Prh8J/QlEYKwZd6vPblEmr89gotBqefrJw8+Hy8cbR gtXS/sn/D9Ybq0Cjo/3K9m17+C6aXtdmEBy3Udi95PblNWPjCQGNLQxzJ0SKqcp4 2Vjm8wP+nQPakrfI3jYfHJZZk/bnOCT8/hrnlarmXhEMiZcEBHEJknTvn8UtdekH ErLAT9NRfXSi3Pu55TVWQTHe9njNYjBAmeQ0IDM/iQKnhFEgqVpzBb4op8zS00Fj n7IPbL1w4zvazgrXeqz4hQKsMVzSRFjh9nCAMQuyHtWbdjbc5lmMwJXcFcM+mahL DEjDfTNYHl/RX9A/16MVby3YSXs46Jhok15h2KsRZuwjc0J1CQbZoDNWycVsjEpQ Fcp74baOg02Z9kAAB5UC =yxX6 -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--