From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 17/33] block: Accept device model name for x-blockdev-remove-medium
Date: Mon, 26 Sep 2016 15:08:09 +0200 [thread overview]
Message-ID: <20160926130809.GG6093@noname.str.redhat.com> (raw)
In-Reply-To: <651b16ea-95f1-513e-ebf8-4c2e0203eb66@redhat.com>
Am 26.09.2016 um 12:59 hat Paolo Bonzini geschrieben:
> On 22/09/2016 18:29, Kevin Wolf wrote:
> > - qmp_x_blockdev_remove_medium(device, &err);
> > + qmp_x_blockdev_remove_medium(true, device, false, NULL, errp);
> > if (err) {
> > error_propagate(errp, err);
> > goto fail;
>
> Bug: &err changed to errp, so err is always NULL.
&err vs. errp is kind of hard to spot in a diff. Maybe a good reason to
stick with "local_err" rather than "err" where we introduce new local
error variables.
Anyway, patch sent.
Kevin
next prev parent reply other threads:[~2016-09-26 13:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 16:29 [Qemu-devel] [PULL 00/33] Block layer patches Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 01/33] qcow2: fix encryption during cow of sectors Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 02/33] hmp: Remove dead code in hmp_qemu_io() Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 03/33] tests: allow to specify list of formats to test for check-block.sh Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 04/33] block: Remove bdrv_is_snapshot Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 05/33] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 06/33] block: Update bs->open_flags earlier in bdrv_open_common() Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 07/33] block: Add "read-only" to the options QDict Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 08/33] block: Don't queue the same BDS twice in bdrv_reopen_queue_child() Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 09/33] commit: Add 'base' to the reopen queue before 'overlay_bs' Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 10/33] block: rename "read-only" to BDRV_OPT_READ_ONLY Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 11/33] block: Fix 'since' for compressed Drive/BlockdevBackup Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 12/33] block: Add blk_by_dev() Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 13/33] qdev-monitor: Factor out find_device_state() Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 14/33] qdev-monitor: Add blk_by_qdev_id() Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 15/33] block: Accept device model name for blockdev-open/close-tray Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 16/33] block: Accept device model name for x-blockdev-insert-medium Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 17/33] block: Accept device model name for x-blockdev-remove-medium Kevin Wolf
2016-09-26 10:59 ` Paolo Bonzini
2016-09-26 13:08 ` Kevin Wolf [this message]
2016-09-22 16:29 ` [Qemu-devel] [PULL 18/33] block: Accept device model name for eject Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 19/33] block: Accept device model name for blockdev-change-medium Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 20/33] block: Accept device model name for block_set_io_throttle Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 21/33] qemu-iotests/118: Test media change with qdev name Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 22/33] qemu-iotests/041: Avoid blockdev-add with id Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 23/33] qemu-iotests/067: " Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 24/33] qemu-iotests/071: " Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 25/33] qemu-iotests/081: " Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 26/33] qemu-iotests/087: " Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 27/33] qemu-iotests/117: " Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 28/33] qemu-iotests/118: " Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 29/33] qemu-iotests/124: " Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 30/33] qemu-iotests/139: " Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 31/33] block: Avoid printing NULL string in error messages Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 32/33] qemu-iotests/141: Avoid blockdev-add with id Kevin Wolf
2016-09-22 16:29 ` [Qemu-devel] [PULL 33/33] block: Remove BB interface from blockdev-add/del Kevin Wolf
2016-09-23 11:12 ` [Qemu-devel] [PULL 00/33] Block layer patches Peter Maydell
2016-09-23 11:41 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926130809.GG6093@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).