From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37168)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1boTnd-0002Rh-T1
	for qemu-devel@nongnu.org; Mon, 26 Sep 2016 07:10:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1boTnZ-00081b-FW
	for qemu-devel@nongnu.org; Mon, 26 Sep 2016 07:10:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47940)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1boTnZ-00081Q-8x
	for qemu-devel@nongnu.org; Mon, 26 Sep 2016 07:10:13 -0400
Date: Mon, 26 Sep 2016 13:10:08 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20160926131008.116dfc3f@nial.brq.redhat.com>
In-Reply-To: <9664929b-6b84-ae11-0682-3743e7a78238@redhat.com>
References: <1474548655-157373-1-git-send-email-imammedo@redhat.com>
	<1474548655-157373-8-git-send-email-imammedo@redhat.com>
	<fc265999-c824-8b23-30f5-094e57b309a2@redhat.com>
	<20160922180017.1f35fc5a@nial.brq.redhat.com>
	<9664929b-6b84-ae11-0682-3743e7a78238@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID
 property to 32bit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, rkrcmar@redhat.com, ehabkost@redhat.com, mst@redhat.com, kevin@koconnor.net, lersek@redhat.com, chao.gao@intel.com, peterx@redhat.com, liuxiaojian6@huawei.com

On Thu, 22 Sep 2016 18:16:47 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 22/09/2016 18:00, Igor Mammedov wrote:
> > > Why not just return initial_apic_id?  This is the meaning the property
> > > had before your patch.  
> > 
> > initial_apic_id is immutable but 'id' could be changed at runtime by guest in xAPIC mode
> > so returned value depends on xAPIC/x2APIC mode  
> 
> Understood, but this is just a possibly poorly-named property.  "id"
> (e.g. from info qtree as opposed to info lapic) used to be the initial
> APIC ID always, even in x2APIC mode.

'info qtree' doesn't show CPUs anymore (since ICC bus has been removed),
but if it were it would show effective APIC ID. Same applie[ds] for
reading property value with qom-get.

> 
> Not a big deal, but thought I'd mention it since you can keep using
> static properties.
PS:
changing initial APIC ID from guest probably wouldn't work anyway
and beak somewhere else, so we could just continue to ignore
it and use static properties for now if you prefer.


> 
> Paolo
> 
> > so I'm just following spec here.