qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 4/5] trace: [tcg] Do not generate TCG code to trace dinamically-disabled events
Date: Mon, 26 Sep 2016 14:41:30 +0100	[thread overview]
Message-ID: <20160926134130.GD14950@stefanha-x1.localdomain> (raw)
In-Reply-To: <147395465853.2399.8315639698512911211.stgit@fimbulvetr.bsc.es>

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

On Thu, Sep 15, 2016 at 05:50:58PM +0200, Lluís Vilanova wrote:

In the subject line:
s/dinamically-disabled/dynamically/

>      for e in events:
> +        # tracer without checks
> +        out('',
> +            'static inline void __nocheck__%(api)s(%(args)s)',

In QEMU we avoid using double underscore since that part of the
namespace is reserved according to the C standard:

"7.1.3 Reserved identifiers
[...]
All identifiers that begin with an underscore and either an uppercase
letter or another underscore are always reserved for any use."

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  reply	other threads:[~2016-09-26 13:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 15:50 [Qemu-devel] [PATCH v2 0/5] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches Lluís Vilanova
2016-09-15 15:50 ` [Qemu-devel] [PATCH v2 1/5] exec: [tcg] Refactor flush of per-CPU virtual TB cache Lluís Vilanova
2016-09-15 15:50 ` [Qemu-devel] [PATCH v2 2/5] exec: [tcg] Use multiple physical TB caches Lluís Vilanova
2016-09-15 15:50 ` [Qemu-devel] [PATCH v2 3/5] exec: [tcg] Switch physical TB cache based on vCPU tracing state Lluís Vilanova
2016-09-15 15:50 ` [Qemu-devel] [PATCH v2 4/5] trace: [tcg] Do not generate TCG code to trace dinamically-disabled events Lluís Vilanova
2016-09-26 13:41   ` Stefan Hajnoczi [this message]
2016-09-26 16:12     ` Lluís Vilanova
2016-09-15 15:51 ` [Qemu-devel] [PATCH v2 5/5] trace: [tcg, trivial] Re-align generated code Lluís Vilanova
2016-09-26 13:37 ` [Qemu-devel] [PATCH v2 0/5] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160926134130.GD14950@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).