From: Stefan Hajnoczi <stefanha@gmail.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-block@nongnu.org, kwolf@redhat.com, pbonzini@redhat.com,
qemu-stable@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 0/1] ahci: fix ncq aiocb-related segfault
Date: Mon, 26 Sep 2016 17:10:40 +0100 [thread overview]
Message-ID: <20160926161040.GA26155@stefanha-x1.localdomain> (raw)
In-Reply-To: <1474575040-32079-1-git-send-email-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
On Thu, Sep 22, 2016 at 04:10:39PM -0400, John Snow wrote:
> Fix ncq_cb to prevent a segfault on sys_reset.
>
> John Snow (1):
> ahci: clear aiocb in ncq_cb
>
> hw/ide/ahci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --
> 2.7.4
Maybe worth adding as a clarification:
The issue is when bdrv_aio_cancel() is called after ncq_cb() was already
invoked. The aiocb will be a dangling pointer.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2016-09-26 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 20:10 [Qemu-devel] [PATCH 0/1] ahci: fix ncq aiocb-related segfault John Snow
2016-09-22 20:10 ` [Qemu-devel] [PATCH 1/1] ahci: clear aiocb in ncq_cb John Snow
2016-09-26 16:10 ` Stefan Hajnoczi [this message]
2016-09-26 18:34 ` [Qemu-devel] [Qemu-block] [PATCH 0/1] ahci: fix ncq aiocb-related segfault John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926161040.GA26155@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).