From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58414)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1boYYr-0007mh-P5
	for qemu-devel@nongnu.org; Mon, 26 Sep 2016 12:15:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1boYYo-0007hv-Ug
	for qemu-devel@nongnu.org; Mon, 26 Sep 2016 12:15:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38030)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1boYYo-0007hn-OU
	for qemu-devel@nongnu.org; Mon, 26 Sep 2016 12:15:18 -0400
Date: Mon, 26 Sep 2016 17:15:15 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20160926161515.GA25705@stefanha-x1.localdomain>
References: <147487882735.6679.8076815106195077844.stgit@bahia>
	<147487884587.6679.6170297932839464278.stgit@bahia>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="oyUTqETQ0mS9luUI"
Content-Disposition: inline
In-Reply-To: <147487884587.6679.6170297932839464278.stgit@bahia>
Subject: Re: [Qemu-devel] [PATCH v3 2/9] virtio-blk: make some functions
 static
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Max Reitz <mreitz@redhat.com>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>


--oyUTqETQ0mS9luUI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 26, 2016 at 10:34:05AM +0200, Greg Kurz wrote:
> Some functions that were called from the dataplane code are now only used
> locally:
>=20
> virtio_blk_init_request()
> virtio_blk_handle_request()
> virtio_blk_submit_multireq()
>=20
> since commit "03de2f527499 virtio-blk: do not use vring in dataplane", and
>=20
> virtio_blk_free_request()
>=20
> since commit "6aa46d8ff1ee virtio: move VirtQueueElement at the beginning
> of the structs".
>=20
> This patch converts them to static.
>=20
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> v3: This was "virtio-blk: turn virtio_blk_handle_request() into a static
>     function" in v2. It turns out that there are some more candidates.
> ---
>  hw/block/virtio-blk.c          |   10 +++++-----
>  include/hw/virtio/virtio-blk.h |    8 --------
>  2 files changed, 5 insertions(+), 13 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--oyUTqETQ0mS9luUI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJX6UmTAAoJEJykq7OBq3PIXbQH/24I8Pnsq0nqcEXYI5ZsR9jd
znlTJ2P22NmtjFncI03VdN7cUcs5D3XfPIxdI0KlwWHwhQcMTRPVLmyCsmIArwkO
GOrnxAmeIFwOCQe2vy7QWwefgwSv7lfh1xWDiQ5gfbFNkZO8iSgNav2ZkpZyy8U5
qIFbCB6BDTqY9KB4zatdI3aiqoEEVHCI0GRF0fypW3yxTeL7Oez7dF50+FnDa+na
FQlI/9V1WxTbJFotYthUQ3S53O5yAXembvQV8jgzp5YqKzbCUI/o9YISxngk8A6V
9fIwxqwWKkyKtl1Y3SmCy5UBAKfbOfBBB6ZLwkmU7NREFKqyWrTvVE531GhgD/Y=
=fZtF
-----END PGP SIGNATURE-----

--oyUTqETQ0mS9luUI--