From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boihu-0005ZP-JX for qemu-devel@nongnu.org; Mon, 26 Sep 2016 23:05:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boihr-0003DB-Bh for qemu-devel@nongnu.org; Mon, 26 Sep 2016 23:05:22 -0400 Received: from ozlabs.org ([103.22.144.67]:48013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boihq-0002r4-JM for qemu-devel@nongnu.org; Mon, 26 Sep 2016 23:05:19 -0400 Date: Tue, 27 Sep 2016 12:39:59 +1000 From: David Gibson Message-ID: <20160927023959.GD15376@umbus.fritz.box> References: <1474899464-14849-1-git-send-email-felipe@nutanix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="76DTJ5CE0DCVQemd" Content-Disposition: inline In-Reply-To: <1474899464-14849-1-git-send-email-felipe@nutanix.com> Subject: Re: [Qemu-devel] [PATCH] spapr_vscsi: fix build error introduced by f19661c8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Felipe Franciosi Cc: Laurent Vivier , Eric Blake , "qemu-devel@nongnu.org" --76DTJ5CE0DCVQemd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 26, 2016 at 03:17:44PM +0100, Felipe Franciosi wrote: > A typo introduced in f19661c8 prevents qemu from building when configured > with --enable-trace-backend=3Ddtrace. >=20 > Signed-off-by: Felipe Franciosi Applied to ppc-for-2.8, thanks. > --- > hw/scsi/spapr_vscsi.c | 2 +- > hw/scsi/trace-events | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c > index d8a2296..6090a20 100644 > --- a/hw/scsi/spapr_vscsi.c > +++ b/hw/scsi/spapr_vscsi.c > @@ -658,7 +658,7 @@ static void vscsi_process_login(VSCSIState *s, vscsi_= req *req) > struct srp_login_rsp *rsp =3D &iu->srp.login_rsp; > uint64_t tag =3D iu->srp.rsp.tag; > =20 > - trace_spapr_vscsi__process_login(); > + trace_spapr_vscsi_process_login(); > =20 > /* TODO handle case that requested size is wrong and > * buffer format is wrong > diff --git a/hw/scsi/trace-events b/hw/scsi/trace-events > index d1995b8..4a2e5d6 100644 > --- a/hw/scsi/trace-events > +++ b/hw/scsi/trace-events > @@ -225,7 +225,7 @@ spapr_vscsi_command_complete_sense_data2(unsigned s8,= unsigned s9, unsigned s10, > spapr_vscsi_command_complete_status(uint32_t status) "Command complete e= rr=3D%"PRIu32 > spapr_vscsi_save_request(uint32_t qtag, unsigned desc, unsigned offset) = "saving tag=3D%"PRIu32", current desc#%u, offset=3D0x%x" > spapr_vscsi_load_request(uint32_t qtag, unsigned desc, unsigned offset) = "restoring tag=3D%"PRIu32", current desc#%u, offset=3D0x%x" > -spapr_vscsi__process_login(void) "Got login, sending response !" > +spapr_vscsi_process_login(void) "Got login, sending response !" > spapr_vscsi_queue_cmd_no_drive(uint64_t lun) "Command for lun %08" PRIx6= 4 " with no drive" > spapr_vscsi_queue_cmd(uint32_t qtag, unsigned cdb, const char *cmd, int = lun, int ret) "Queued command tag 0x%"PRIx32" CMD 0x%x=3D%s LUN %d ret: %d" > spapr_vscsi_do_crq(unsigned c0, unsigned c1) "crq: %02x %02x ..." --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --76DTJ5CE0DCVQemd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX6dv/AAoJEGw4ysog2bOSAgAQALLg6halHabrNpY20jboCyzQ 8aZawvWBLV71VIJFsmuzMcyV+aC9bDYRmCfevfaOboKpJScifzv9OBbbT7dVnV/b vwksrFy6HTmVbu/BH+6F9fv7HbtmSnyRc7EszmYeOzcIaCmiYQzyFOzTZWfy9SFj 0JWogbvKIqsSlzjqDzmA3yK/7twq2LFgLqxhNpjAzOZqliOvgqP/etDxp0XFoftm w85X5z27og0h6H79rMu/fdLLee3oOIX0CQMgPbaRtsE6YnEtM3PSpW5itvNcGm30 +hrh4+8lo7swFaDAImRxUd+vflVa85wY6zOLFxyVRysorJcE1md+Oo2l1q1Y278a fBM8QPRGc7IeFymKtzFmsY+s/47EU/URKgfgZpikhtrLe49j762Gd9QW3tM8dczy 2Oc9wKNS8R30TG0yALrUejGdkIoehmHEpSMUdTBhQQCE2fecUClA8m3s5KkCoOUD EG600CgH5cfQOAdiezy+5Gs03+g6n4mZP1C/UHJ1SgrSmBtEYLNtjxofh3UuEViR T05StWlzqegnHJF82O728xsHiZQF/fz+PJO3fSCnK8ubZtPNdc9+2vbZMFOI6JhM pbMugj6Jj1DQaAAmXkY09QKQ8LgGv/6dUIxrm+dSkGVW/7dC7MhYKnIHOjPL5+IU C9CiB6p2x6XEJDty1QR2 =VBtN -----END PGP SIGNATURE----- --76DTJ5CE0DCVQemd--