From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bojkR-000701-Ic for qemu-devel@nongnu.org; Tue, 27 Sep 2016 00:12:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bojkN-00011d-9e for qemu-devel@nongnu.org; Tue, 27 Sep 2016 00:12:02 -0400 Received: from ozlabs.org ([103.22.144.67]:50531) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bojkM-00011N-Tv for qemu-devel@nongnu.org; Tue, 27 Sep 2016 00:11:59 -0400 Date: Tue, 27 Sep 2016 14:08:55 +1000 From: David Gibson Message-ID: <20160927040855.GE30322@umbus.fritz.box> References: <1474921408-24710-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mR8QP4gmHujQHb1c" Content-Disposition: inline In-Reply-To: <1474921408-24710-1-git-send-email-hpoussin@reactos.org> Subject: Re: [Qemu-devel] [PATCH v2 0/6] intc: change 'info irq' and 'info pic' to be target-agnostic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Herv=E9?= Poussineau Cc: qemu-devel@nongnu.org, Paolo Bonzini , Luiz Capitulino --mR8QP4gmHujQHb1c Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 26, 2016 at 10:23:22PM +0200, Herv=E9 Poussineau wrote: > Hi, >=20 > This patchset aims at genericizing the 'info irq' and 'info pic' HMP comm= ands, so > that it is available on all machines and can display details about more t= han one > interrupt controller per machine. >=20 > Patch 1 adds a new interface InterruptStatsProvider, which is used to: > - gather statistics for the 'info irq' command > - print some text when 'info pic' is called >=20 > Patches 2 to 4 implement InterruptStatsProvider interface on interrupt co= ntrollers > which have ad-hock code to handle 'info irq'/'info pic' commands. >=20 > Patch 5 removes ad-hock code, and replaces it by a generic version. You c= an get > details about multiple interrupt controllers per machine starting here. >=20 > Patch 6 makes 'info irq'/'info pic' commands available on all architectur= es. > For example, Alpha clipper machine is now able to display details about t= he > i8259 interrupt controller. Thanks for doing this. I didn't spot your first version of this, but it's a rather more thorough approach to some cleanups I attempted a while back, but never got around to completing. Looks like a nice approach. >=20 > Changes since v1: > - renamed interface from IntCtrl to InterruptStatsProvider >=20 > Herv=E9 >=20 > Herv=E9 Poussineau (6): > intc: add an interface to gather statistics/informations on interrupt > controllers > intc/i8259: implement InterruptStatsProvider interface > intc/slavio_intctl: implement InterruptStatsProvider interface > intc/lm32_pic: implement InterruptStatsProvider interface > intc: make HMP 'info irq' and 'info pic' commands use > InterruptStatsProvider interface > intc: make HMP 'info irq' and 'info pic' commands available on all > targets >=20 > hmp-commands-info.hx | 17 +---------- > hmp.c | 65 +++++++++++++++++++++++++++++++++++++++++ > hmp.h | 2 ++ > hw/intc/Makefile.objs | 1 + > hw/intc/i8259.c | 73 +++++++++++++++++++++++-----------------= ------ > hw/intc/intc.c | 41 ++++++++++++++++++++++++++ > hw/intc/lm32_pic.c | 63 ++++++++++++++++++--------------------- > hw/intc/slavio_intctl.c | 67 ++++++++++++++++++++++------------------= -- > hw/sparc/sun4m.c | 15 +--------- > include/hw/i386/pc.h | 2 -- > include/hw/intc/intc.h | 30 +++++++++++++++++++ > include/hw/lm32/lm32_pic.h | 3 -- > include/hw/sparc/sun4m.h | 8 ----- > monitor.c | 6 ---- > 14 files changed, 241 insertions(+), 152 deletions(-) > create mode 100644 hw/intc/intc.c > create mode 100644 include/hw/intc/intc.h >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --mR8QP4gmHujQHb1c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX6fDVAAoJEGw4ysog2bOS8SUQAMCJNIPeryCCjCJ25th7uT1K Vf8X25rtGrvCc5Hz9A2RPq3x5kvyQjE0TQ+acGkfyseqa9HcqsvlAXf9oChSVSww Y2hOmlBxcdAbRY1qmAOeQ1vpdPDYHiH3U/G9sl2GsQ/D361y6yOoGMx8rEtS6CXU EzH5+mH15gWJ3qihb+3U0BGrnd4wMbXrlv4hGBN3KRuq5sQM/llhevUQAgKpn9GD x0sYR/7FqU2sEt1IIiVdPEB4Ud9UGZfd8XlOD2pkjrBe82mo8KMHkbKKtSFt9Mv+ XorPo9647SfOxYmtuDV5asmX/W2iNkE52dauOw0eiheXmjCU8N8ISnM3TLY2dUYU SH8K7oZrI+DlslXsSZWE97C2upyF4gxeaB5ENvG4fX+YKaq4RVwa9Yom2Gt+f5p5 adp3jR91eJmos2Z1ORzfIfawFe3Nwhbw4DLVJ1o3oVooxE82dLqN4ixvIMMQmnIc 928Qu4nufTTljTE3W1zONpqzNyq1ysX7J53xk45QKmFGSeOD7FeCu+wKAWjg5Xa2 EFIXAmWUn1tiIbAAM+YlJQ8vqowu9EkV5gZ+LoWQFKDkrE9ZE7hUlhMN4QKhAa+Z KXzkHdNglTeA5NDa3utyYE0LYxV6ZIONKX/4wc0EQoHXqlDuzKAEiul0pMXKTmjF K36F1fsswzkysXVt1vSC =za+J -----END PGP SIGNATURE----- --mR8QP4gmHujQHb1c--