From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bonif-0004IX-P5 for qemu-devel@nongnu.org; Tue, 27 Sep 2016 04:26:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bonie-0004uT-UP for qemu-devel@nongnu.org; Tue, 27 Sep 2016 04:26:29 -0400 Date: Tue, 27 Sep 2016 10:26:17 +0200 From: Kevin Wolf Message-ID: <20160927082617.GD4090@noname.str.redhat.com> References: <1474641161-10891-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kORqDWCi7qDJ0mEj" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 0/7] block: Make more blockdev-add options work List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-block@nongnu.org, eblake@redhat.com, qemu-devel@nongnu.org --kORqDWCi7qDJ0mEj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Am 26.09.2016 um 19:10 hat Max Reitz geschrieben: > It's a bit funny now how blockdev_init() and > extract_common_blockdev_options() are actually used by neither > blockdev-add nor -blockdev, but only by drive_new() (which happily > advertises blockdev_init() to be shared with blockev-add, though). Yes. Essentially drive_new() is now the clean wrappers that map legacy syntax to the modern options, whereas blockdev_init() is left as the place for the messy stuff. Maybe we can get rid of it sooner or later. Kevin --kORqDWCi7qDJ0mEj Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJX6i0pAAoJEH8JsnLIjy/W5GMP/3If3IBfTw/KUlPdkvEl9iA7 wwMPJmx0FowPxwYPDfr6+/VgpaTODKGCLJdx6fQTdWzkLikDAC0N4OIlnwBD0RGf 7+ZLk79VgCikU5Dhn/zm6k2nsrxCWl4vpCTtbhFoK1dLU1SYssUBnTeta5VlS8N2 hS6WLn6cnLw8hadd58G2AkIiiKuuY8mJZf3YuHuYfVCMqcPQCxa0g/rfrVGMW9M8 /caKoP8FQjIcXWsmRzYV+tcnOI8LqbdqLmgUUmkCEkrmTkvH+XAtuvlmmfi2pURF Q6Zs6/LzQP2HPwjZoug+wzgtJ/ZMEUCd6mUVQrcxWnkMZDR2pBoHBc/dYEb1KYLx LahU+zu0fCeyRYgJ2XS9VakTJpvvU28nBydFjric4tZ2FFGpdxunJpOBo2aNWeMo K9SYx6Tb8OLNQvF9dm5BELJOpMbrgXyW/Kx31YsG8+skkUnORhqlocU87ckC4sEN 2BY/8JJQqFWmaPMwF9eULCtbT1RK8OYTvDeAU2sD5LLpwYqt5gqUiq6LjSN9tmHY yVZ3BkG5fXG+uTgwHnBdpMsfJSTnDskoJyANhODk8Sr0QR2bmwNw9jGW1EB24BSl RexYe9UVoWm5Quty1tB4TCR78KPGUhGPWGTr/ZmJqAi+3lVLUrOpsiQ4NiUU3Y9e 4rrC60/a7UDJoKYNMPlo =zHM/ -----END PGP SIGNATURE----- --kORqDWCi7qDJ0mEj--