From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bopKq-0000tm-6M for qemu-devel@nongnu.org; Tue, 27 Sep 2016 06:10:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bopKl-0002VA-VY for qemu-devel@nongnu.org; Tue, 27 Sep 2016 06:09:59 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bopKl-0002V5-PS for qemu-devel@nongnu.org; Tue, 27 Sep 2016 06:09:55 -0400 Received: by mail-wm0-f65.google.com with SMTP id b184so351769wma.3 for ; Tue, 27 Sep 2016 03:09:55 -0700 (PDT) Date: Tue, 27 Sep 2016 11:08:53 +0100 From: Stefan Hajnoczi Message-ID: <20160927100853.GD563@stefanha-x1.localdomain> References: <1474291685-24226-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qGV0fN9tzfkG3CxV" Content-Disposition: inline In-Reply-To: <1474291685-24226-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/3] virtio: detach VirtQueueElements freed by reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, lprosek@redhat.com, "Michael S. Tsirkin" --qGV0fN9tzfkG3CxV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 19, 2016 at 02:28:02PM +0100, Stefan Hajnoczi wrote: > virtio-blk and virtio-serial need to free VirtQueueElements during device > reset. Simply calling g_free(elem) is not enough because the scatter-gat= her > list should be unmapped and vq->inuse must be decremented. >=20 > These patches address the issue. I am not including a patch that changes > vq->inuse =3D 0 to assert(!vq->inuse) in virtio_reset() yet because virti= o-9p, > virtio-gpu, and virtio-net have code paths that do not decrement vq->inus= e. >=20 > Stefan Hajnoczi (3): > virtio: add virtio_detach_element() > virtio-blk: add missing virtio_detach_element() call > virtio-serial: add missing virtio_detach_element() call >=20 > hw/block/virtio-blk.c | 1 + > hw/char/virtio-serial-bus.c | 14 ++++++++++++++ > hw/virtio/virtio.c | 27 +++++++++++++++++++++++++-- > include/hw/virtio/virtio.h | 2 ++ > 4 files changed, 42 insertions(+), 2 deletions(-) Ping? --qGV0fN9tzfkG3CxV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJX6kU1AAoJEJykq7OBq3PI3cEIALdIE/m5MxPMDE+4J2FTyaul c8wTmoOo8BKBSMfh5fTRJoVzfVxTl3iVO9Hx2otXVPH49WmN1utdlmGQdhDBaYV0 Z8dgW2NsDTWuXdse4QiECAoQQ0xUX1OzD1B8IYsQzJkh57oxYUOH5IwvLcmNd8aU KvHmYHfbwQWN1kSU9QK8G1DR/yECqh6z3AGV9RdPFk/xPKUb+THSLmSRaTkc789k jd2JV8W89DOEaGul1khvbKYDOp2Jjdm+gr1UMCZDiuc/wB8/OpLP6MvJEmlwCmKT Gl6mL6X73ENjTpELzCZbfohP93wwMzojn3WhcrPJtxU+AE8+F1os/jY0Bgz7f0s= =qEoz -----END PGP SIGNATURE----- --qGV0fN9tzfkG3CxV--