From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bopOZ-0003st-EM for qemu-devel@nongnu.org; Tue, 27 Sep 2016 06:13:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bopOX-0004Bj-EV for qemu-devel@nongnu.org; Tue, 27 Sep 2016 06:13:50 -0400 Date: Tue, 27 Sep 2016 18:13:38 +0800 From: Fam Zheng Message-ID: <20160927101338.GB13510@lemon> References: <1474968813-14181-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474968813-14181-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] block: Turn on "unmap" in active commit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , qemu-block@nongnu.org, Max Reitz On Tue, 09/27 17:33, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in the virt-sparsify use case, where a temporary > overlay is created and fstrim'ed before commiting back, to free space in > the original image. > > This also enables it for block-commit. > > Signed-off-by: Fam Zheng Sent too soon. I see a number of iotests failures (020 040 097 129), still investigating. Fam