qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: "Gonglei (Arei)" <arei.gonglei@huawei.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	John Snow <jsnow@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel
Date: Tue, 27 Sep 2016 11:14:35 +0100	[thread overview]
Message-ID: <20160927101435.GJ3967@redhat.com> (raw)
In-Reply-To: <20160923095905.GJ8832@lemon>

On Fri, Sep 23, 2016 at 05:59:05PM +0800, Fam Zheng wrote:
> On Fri, 09/23 09:39, Gonglei (Arei) wrote:
> > 
> > Hi Fam,
> > 
> > 
> > > -----Original Message-----
> > > From: Qemu-devel
> > > [mailto:qemu-devel-bounces+arei.gonglei=huawei.com@nongnu.org] On
> > > Behalf Of Fam Zheng
> > > Sent: Friday, September 23, 2016 3:58 PM
> > > To: John Snow
> > > Cc: pbonzini@redhat.com; qemu-devel@nongnu.org
> > > Subject: Re: [Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel
> > > 
> > > On Wed, 09/21 14:24, John Snow wrote:
> > > >
> > > >
> > > > On 08/12/2016 05:19 AM, Fam Zheng wrote:
> > > > > Previously all test cases in a category, such as check-qtest-y, are
> > > > > executed in a single long gtester command. This patch separates each
> > > > > test into its own make target to allow better parallism.
> > > > >
> > 
> > That's will be great if we can specify a test to run, especially for the scenario
> > which add one use qtest case.
> > 
> > For example: 
> > 
> >  # make check test-crypto-cipher
> > 
> > then only run the tests/ test-crypto-cipher. 
> > 
> > Do you think it makes sense?
> 
> Or more likely:
> 
>     # make check TESTS="test-crypto-cipher test-crypto-hash ..."
> 
> Usually I just extract the gtester command line with V=1 and run it from my
> shell prompt.  Feel free to send a patch, though.

Shouldn't even need todo that in most cases - I tend to just do

  make tests/test-crypto-cipher && ./tess/test-crypto-cipher

If there are tests which rely on some environment set by the Makefile,
then really they should be fixed to have sensible defaults so that they
can be directly executed.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

  parent reply	other threads:[~2016-09-27 10:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-12  9:19 [Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel Fam Zheng
2016-09-21 18:24 ` John Snow
2016-09-23  7:58   ` Fam Zheng
2016-09-23  9:39     ` Gonglei (Arei)
2016-09-23  9:59       ` Fam Zheng
2016-09-24  2:37         ` Gonglei (Arei)
2016-09-27 10:14         ` Daniel P. Berrange [this message]
2016-09-28  1:31           ` Gonglei (Arei)
2016-09-28  1:45             ` Fam Zheng
2016-09-28  1:54               ` Gonglei (Arei)
2016-09-28  2:10                 ` Fam Zheng
2016-09-27 10:17     ` Daniel P. Berrange
2016-09-27 10:58       ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160927101435.GJ3967@redhat.com \
    --to=berrange@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).